Page MenuHomePhabricator
Create Task
Maniphest T235259

Finish merging modules into wikibase.ui.entityViewInit
Closed, ResolvedPublic
Actions

Description

This is current ones that (probably) can be merged:

image.png (251×4 px, 125 KB)

This blocks merging more stuff (T233792: Merge dependencies into jquery.view.ViewFactory)

Details

SubjectRepoBranchLines +/-
Horizontal merge of "bad value" modules of jquery.valueviewmediawiki/extensions/Wikibasemaster+4 -13
Merge wikibase.ValueFormatterFactory into entityViewInitmediawiki/extensions/Wikibasemaster+7 -16
Horizontal merge of wb.api.(Format|Parse)ValueCallermediawiki/extensions/Wikibasemaster+4 -15
Merge ToolbarFactory to entityViewInitmediawiki/extensions/Wikibasemaster+68 -57
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup claimed this task.Oct 11 2019, 11:02 AM
Ladsgroup created this task.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptOct 11 2019, 11:02 AM
Ladsgroup added a parent task: T233792: Merge dependencies into jquery.view.ViewFactory.Oct 11 2019, 11:02 AM
Ladsgroup moved this task from Backlog to Doing on the RL Module Terminators Trailblazing board.Oct 11 2019, 11:05 AM
gerritbot added a comment.Oct 12 2019, 12:07 AM

Change 542634 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Merge ToolbarFactory to entityViewInit

https://gerrit.wikimedia.org/r/542634

gerritbot added a project: Patch-For-Review.Oct 12 2019, 12:07 AM
Ladsgroup moved this task from Doing to Peer Review on the RL Module Terminators Trailblazing board.Oct 14 2019, 3:37 PM
Ladsgroup moved this task from Peer Review to Doing on the RL Module Terminators Trailblazing board.Oct 15 2019, 3:43 PM
Ladsgroup moved this task from Doing to Peer Review on the RL Module Terminators Trailblazing board.Oct 16 2019, 11:55 AM
gerritbot added a comment.Oct 16 2019, 3:04 PM

Change 542634 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Merge ToolbarFactory to entityViewInit

https://gerrit.wikimedia.org/r/542634

Maintenance_bot removed a project: Patch-For-Review.Oct 16 2019, 3:10 PM
Ladsgroup moved this task from Peer Review to Doing on the RL Module Terminators Trailblazing board.Oct 16 2019, 3:13 PM
gerritbot added a comment.Oct 16 2019, 3:23 PM

Change 543480 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Horizontal merge of wb.api.(Format|Parse)ValueCaller

https://gerrit.wikimedia.org/r/543480

gerritbot added a project: Patch-For-Review.Oct 16 2019, 3:23 PM
gerritbot added a comment.Oct 16 2019, 3:56 PM

Change 543480 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Horizontal merge of wb.api.(Format|Parse)ValueCaller

https://gerrit.wikimedia.org/r/543480

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.3; 2019-10-22).Oct 16 2019, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 16 2019, 4:10 PM
gerritbot added a comment.Oct 16 2019, 4:10 PM

Change 543486 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Finish merging dependencies into entityViewInit

https://gerrit.wikimedia.org/r/543486

gerritbot added a project: Patch-For-Review.Oct 16 2019, 4:10 PM
Ladsgroup moved this task from Doing to Peer Review on the RL Module Terminators Trailblazing board.Oct 17 2019, 12:54 PM
gerritbot added a comment.Oct 17 2019, 1:50 PM

Change 543486 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Merge wikibase.ValueFormatterFactory into entityViewInit

https://gerrit.wikimedia.org/r/543486

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2019, 2:10 PM
Ladsgroup moved this task from Incoming to Done on the User-Ladsgroup board.Oct 17 2019, 2:39 PM

I looked at everything that's remain and nothing can be merged now.

Ladsgroup moved this task from Peer Review to Done on the RL Module Terminators Trailblazing board.Oct 17 2019, 2:40 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 18 2019, 5:28 PM
gerritbot added a comment.Oct 21 2019, 10:57 AM

Change 544862 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Horizontal merge of "bad value" modules of jquery.valueview

https://gerrit.wikimedia.org/r/544862

gerritbot added a project: Patch-For-Review.Oct 21 2019, 10:57 AM
gerritbot added a comment.Oct 21 2019, 11:12 AM

Change 544862 abandoned by Ladsgroup:
Horizontal merge of "bad value" modules of jquery.valueview

Reason:
Not now :(

https://gerrit.wikimedia.org/r/544862

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2019, 12:11 PM
Ladsgroup closed this task as Resolved.Oct 23 2019, 10:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits