Page MenuHomePhabricator
Create Task
Maniphest T235415

Copy uploads not working for https://www.bollywoodhungama.com
Closed, ResolvedPublic
Actions

Description

Showing copy uploads are not available from this domain when trying to upload from www.bollywoodhungama.com.

See T203363 for reference.

Details

SubjectRepoBranchLines +/-
wgCopyUploadDomains: Partial revert of I30a4b8c9bb9c1240d7e7422446af55ad50c41e70 to make upload working from bollywoodhungama.*operations/mediawiki-configmaster+1 -0
Fix wrong domain in wgCopyUploadDomains added in T203363operations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedUrbanecmT203363 Please add http://www.bollywoodhungama.com to the wgCopyUploadsDomains whitelist of Wikimedia Commons
ResolvedKizuleT235415 Copy uploads not working for https://www.bollywoodhungama.com
· · ·

Event Timeline

Jony created this task.Oct 14 2019, 9:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2019, 9:50 AM
Jony added a parent task: T203363: Please add http://www.bollywoodhungama.com to the wgCopyUploadsDomains whitelist of Wikimedia Commons.Oct 14 2019, 9:51 AM
Kizule claimed this task.Oct 14 2019, 10:06 AM
Kizule subscribed.

In configuration was added wrong domain, I will fix this.

Restricted Application added a project: User-Kizule. · View Herald TranscriptOct 14 2019, 10:06 AM
gerritbot added a comment.Oct 14 2019, 10:09 AM

Change 542891 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[operations/mediawiki-config@master] Fix wrong domain in wgCopyUploadDomains added in T203363

https://gerrit.wikimedia.org/r/542891

gerritbot added a project: Patch-For-Review.Oct 14 2019, 10:09 AM
gerritbot added a comment.Oct 14 2019, 11:29 AM

Change 542891 merged by jenkins-bot:
[operations/mediawiki-config@master] Fix wrong domain in wgCopyUploadDomains added in T203363

https://gerrit.wikimedia.org/r/542891

Kizule closed this task as Resolved.Oct 14 2019, 11:31 AM

Should works now. If still you have problem, please reopen task.

Stashbot mentioned this in T203363: Please add http://www.bollywoodhungama.com to the wgCopyUploadsDomains whitelist of Wikimedia Commons.Oct 14 2019, 11:33 AM

Mentioned in SAL (#wikimedia-operations) [2019-10-14T11:33:45Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: a295cc7: Fix wrong domain in wgCopyUploadDomains added in T203363 (T235415) (duration: 00m 51s)

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2019, 12:10 PM
Jony added a comment.Oct 14 2019, 5:30 PM

@Zoranzoki21 unable to upload, because www.bollywoodhungama.com have no any file format in the url, like .jpg or .png. even there is no programming filename extensions also like .php or .html.

Kizule added a comment.Oct 17 2019, 12:47 PM
In T235415#5573412, @Jony wrote:

@Zoranzoki21 unable to upload, because www.bollywoodhungama.com have no any file format in the url, like .jpg or .png. even there is no programming filename extensions also like .php or .html.

Really?

Jony added a comment.Oct 17 2019, 1:19 PM

Yes

Jony reopened this task as Open.EditedMay 10 2020, 3:38 AM

Hi @Zoranzoki21, could you please make the domain in wgCopyUploadDomains as *.bollywoodhungama.in or *.bollywoodhungama.*. hope this will work well. We got another URL that could be use for copy uploads. Example: https://stat2.bollywoodhungama.in/wp-content/uploads/2020/03/Photos-Shama-Sikander-snapped-at-a-medical-shop-4.jpg Thanks!

RhinosF1 subscribed.May 10 2020, 6:56 AM
Kizule added a comment.EditedMay 10 2020, 11:56 AM

In patch I changed .in to .com

Screenshot_20200510_135336_com.android.chrome.jpg (1×720 px, 355 KB)

Maybe I should just add *.bollywoodhungama.in because *.bollywoodhungama.* won't work.

What you think @Jony?

(CC'ing @Urbanecm just to confirm this).

Kizule moved this task from Incoming to Uploading (upload_by_url and server side upload) on the Commons board.May 10 2020, 11:56 AM
Urbanecm added a comment.May 10 2020, 12:00 PM

Both should work, according to my understanding of the code. However, I'd prefer not whitelisting the TLD part - as it's not guaranteed the domain exists in all TLDs. If multiple TLDs are needed, just add multiple whitelist lines.

Urbanecm added a project: Wikimedia-Site-requests.May 10 2020, 12:00 PM
Jony added a comment.May 10 2020, 2:05 PM

@Zoranzoki21 as @Urbanecm said you can try that. However, if that couldn't then add multiple lines *.bollywoodhungama.in and *.bollywoodhungama.com Thanks.

Urbanecm added a comment.May 10 2020, 3:09 PM

I said it works technically - not that it's preferred. I'm in favor of explicitly adding those two lines.

gerritbot added a comment.May 11 2020, 6:44 PM

Change 595610 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[operations/mediawiki-config@master] wgCopyUploadDomains: Partial revert of I30a4b8c9bb9c1240d7e7422446af55ad50c41e70 to make upload working from bollywoodhungama.*

https://gerrit.wikimedia.org/r/595610

gerritbot added a project: Patch-For-Review.May 11 2020, 6:44 PM
Kizule moved this task from Inbox to To deploy on the User-Kizule board.May 11 2020, 6:46 PM

Will be deployed in next few minutes.

Kizule moved this task from Backlog to To deploy on the Wikimedia-Site-requests board.May 11 2020, 6:46 PM
gerritbot added a comment.May 11 2020, 6:58 PM

Change 595610 merged by jenkins-bot:
[operations/mediawiki-config@master] wgCopyUploadDomains: Partial revert of I30a4b8c9bb9c1240d7e7422446af55ad50c41e70 to make upload working from bollywoodhungama.*

https://gerrit.wikimedia.org/r/595610

Kizule closed this task as Resolved.May 11 2020, 7:00 PM

Should work now.

Stashbot mentioned this in T235414: Deploy core version of watchlist for AMC users.May 11 2020, 7:03 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-11T19:03:24Z] <Zoranzoki21> T235414 is wrong task number, T235415 is correct

Maintenance_bot removed a project: Patch-For-Review.May 11 2020, 7:11 PM
Jony added a comment.May 12 2020, 11:38 AM

Thanks @Zoranzoki21, its working now, https://commons.wikimedia.org/wiki/File:Shama_Sikander_at_medical_shop.jpg

Kizule added a comment.EditedMay 12 2020, 11:39 AM
In T235415#6128916, @Jony wrote:

Thanks @Zoranzoki21, its working now, https://commons.wikimedia.org/wiki/File:Shama_Sikander_at_medical_shop.jpg

@Jony Great!

Jony awarded a token.May 12 2020, 11:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL