Page MenuHomePhabricator

Let GeoLite handle different targets for chapters
Closed, ResolvedPublic

Description

Author: thomas.dalton

Description:
Patch - see description

This patch should allow different fundraising banners to link to different chapter landing pages. To get the banners to do what we want in the UK, the following will need to be added to wherever the globals for meta are defined:

$wgChapterTargets['Help_Us_Change_the_World']['uk']=true;

('uk' may need to be replaced by whatever the geoip calls the UK, use whatever is used as the key in $wgChapterLandingPages)

The same kind of line should be added for any specific target page that exists for a specific chapter. If the array value doesn't exist, it defaults to the standard chapter page (as happens currently).

NB: THIS CODE IS UNTESTED (I don't have a local system with this extension installed and it is far too complicated to set one up and my PHP-fu is insufficient to guarantee it will work by eye)


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz21577

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:48 PM
bzimport set Reference to bz21577.

Assigned to Tomasz Finc for review and application if OK-ed.

thomas.dalton wrote:

What's the point? The fundraiser is over now... Chances are the system will be completely rewritten for next year.

Then the outcome could be "WONTFIX". I cannot assess, Tomas can...

Resolving as we migrated over to LandingCheck for this functionality.