Page MenuHomePhabricator
Create Task
Maniphest T236207

Icon on mapframe's fullscreen button misaligned
Closed, ResolvedPublic
Actions

Description

Since recently icon on mapframe's fullscreen button is no longer centred. E.g. see maps here.

This appears to be due to recent changes to OOUI. Would it be sufficient fix if oo-ui-iconElement-icon style was removed from here too? @Volker_E, could you please have a look.

Details

SubjectRepoBranchLines +/-
Remove override for icon centering as upstream takes care of it nowmediawiki/extensions/Kartographermaster+0 -4
Customize query in gerrit

Related Objects

Event Timeline

Pikne created this task.Oct 22 2019, 7:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2019, 7:41 PM
Aklapper merged a task: T237087: Zoom button messed up in embedded maps.Nov 1 2019, 5:55 AM
Aklapper added a subscriber: kaldari.
gerritbot added a comment.Nov 1 2019, 6:04 PM

Change 547759 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Kartographer@master] Remove override for icon centering as upstream takes care of it now

https://gerrit.wikimedia.org/r/547759

gerritbot added a project: Patch-For-Review.Nov 1 2019, 6:04 PM
Volker_E added a comment.Nov 1 2019, 6:05 PM

Thanks @Pikne for reporting!

Volker_E updated the task description. (Show Details)Nov 1 2019, 6:05 PM
gerritbot added a comment.Nov 1 2019, 6:36 PM

Change 547759 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Remove override for icon centering as upstream takes care of it now

https://gerrit.wikimedia.org/r/547759

Volker_E closed this task as Resolved.Nov 1 2019, 6:37 PM
Volker_E claimed this task.
Volker_E triaged this task as Medium priority.
Volker_E removed projects: Patch-For-Review, OOUI.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.5; 2019-11-05).Nov 1 2019, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits