Maniphest T236411

Remove unused access code revocation code
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Samwalton9-WMF
	Oct 24 2019, 5:14 PM

Tags

Referenced Files

None

Subscribers

Description

When we implemented access code distribution (T202615), we listed them on the per-partner List Applications page. That was then removed (https://github.com/Samwalton9/TWLight/commit/2ac818ae55315b1e6a5f0e177576782e12f3dd64) because we changed the relation from Code-Application to Code-Authorization and the column wasn't working. Now that we're reworking that page entirely (T236284) we have no plans to reinstate the access code revocation feature.

As such we have a few pieces of the codebase that are entirely unused:

partner_unassign_code.html - https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/resources/templates/resources/partner_unassign_code.html
A view, URL, and probably some tests for this functionality.

We should remove this unused code.

Related Objects

Mentioned Here: T202615: Add support for access code tracking
T236284: Explore what 'list application' (/partners/<resource_id>/users/) achieves and figure out better alternatives

Event Timeline

Samwalton9-WMF created this task.Oct 24 2019, 5:14 PM

Restricted Application added subscribers: Sadads, Aklapper. · View Herald TranscriptOct 24 2019, 5:14 PM

Samwalton9-WMF triaged this task as Low priority.Oct 24 2019, 5:15 PM

Samwalton9-WMF added a project: good first task.Oct 28 2019, 11:50 AM

Submitted at https://github.com/WikipediaLibrary/TWLight/pull/341

Ammarpad raised the priority of this task from Low to Medium.Nov 2 2019, 1:29 AM

• AVasanth_WMF moved this task from Open tasks to Done on the Library-Card-Platform board.Nov 2 2019, 3:55 AM

Samwalton9-WMF closed this task as Resolved.Nov 4 2019, 12:19 PM