Page MenuHomePhabricator

Reduce top-margin for checkboxes on Special:Block
Closed, ResolvedPublic

Assigned To
Authored By
Niharika
Oct 28 2019, 12:45 PM
Referenced Files
F30908182: image.png
Oct 28 2019, 7:32 PM
F30908144: image.png
Oct 28 2019, 7:32 PM
F30908165: image.png
Oct 28 2019, 7:32 PM
F30907754: image.png
Oct 28 2019, 5:46 PM
F30907758: image.png
Oct 28 2019, 5:46 PM

Description

  • Reduce top-margin for checkboxes

One small detail for the form, the Sitewide/Partial radio buttons top margin to the parent checkbox seems overly big, it should be reduced, probably by a single page CSS rule for this page to 8px.

  • Reduce top margin for Pages and Namespaces widgets

Event Timeline

Niharika triaged this task as Medium priority.Oct 28 2019, 12:45 PM
Niharika created this task.

Change 546443 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Reduce top margin for block type options on Special:Block

https://gerrit.wikimedia.org/r/546443

@Tchanders Would you provide a before/after screenshot here?

Let's please do the same for the inputs underneath partial?

Also, why is the secondary label for the radio buttons intended, is this Special:Block specific or an upstream bug? It shouldn't be intended.

Change 546443 merged by jenkins-bot:
[mediawiki/core@master] Reduce top margin for block type options on Special:Block

https://gerrit.wikimedia.org/r/546443

Also, why is the secondary label for the radio buttons intended, is this Special:Block specific or an upstream bug?

Appears to be an upstream bug in the radio select widget padding: https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/546682/

Change 546684 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Reduce top margin for multiselect widgets on Special:Block

https://gerrit.wikimedia.org/r/546684

@Volker_E - and for posterity:

Before this taskAfter margin reduction and upstream fix
Vector
image.png (500×897 px, 38 KB)
image.png (478×886 px, 38 KB)
Monobook
image.png (470×813 px, 33 KB)
image.png (465×809 px, 33 KB)

Change 546684 merged by jenkins-bot:
[mediawiki/core@master] Reduce top margin for multiselect widgets on Special:Block

https://gerrit.wikimedia.org/r/546684