Page MenuHomePhabricator

AbuseFilterVariableHolder::getVar: requested unset variable moved_from_namespace in strict mode, filter: 809
Closed, InvalidPublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.35.0-wmf.3

message
AbuseFilterVariableHolder::getVar: requested unset variable moved_from_namespace in strict mode, filter: 809

Impact

i'm not sure, filter can't process properly?

Notes

Logstash has 36m+ hits in last month, not sure since when it happens, since it timeouts on that search. See https://logstash.wikimedia.org/goto/968d6a889e2c8589b6274d276af68272 for more examples.

Details

Request ID
XbgS0gpAIDYAAAs01eQAAABS
Request URL
n/a
Stack Trace
exception.trace
n/a

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2019, 10:25 AM
Urbanecm triaged this task as Unbreak Now! priority.Oct 29 2019, 10:25 AM
Restricted Application added subscribers: Daimona, Liuxinyu970226. · View Herald TranscriptOct 29 2019, 10:25 AM

Triaged as UBN, since it's possible it breaks affected filters.

Daimona closed this task as Invalid.Oct 29 2019, 2:08 PM

That's just debug logging. It was introduced to see how many filters are affected by T230256. As you observed, there are *many* affected filters, hence T230256#5515823 will revert the change.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptOct 29 2019, 2:08 PM

That's just debug logging. It was introduced to see how many filters are affected by T230256. As you observed, there are *many* affected filters, hence T230256#5515823 will revert the change.

Great. I still don't understand how T230256 can affect built-in variables like moved_from_namespace, but that might be just me not understanding the problem properly.

Maybe we should log such debug logging at debug/info (maybe even notice) severity, the warnings really frightened me :-).

That's just debug logging. It was introduced to see how many filters are affected by T230256. As you observed, there are *many* affected filters, hence T230256#5515823 will revert the change.

Great. I still don't understand how T230256 can affect built-in variables like moved_from_namespace

If the action being filtered is not a move, then moved_from_namespace isn't set.

Maybe we should log such debug logging at debug/info (maybe even notice) severity, the warnings really frightened me :-).

I wanted to make log entries visible, but certainly didn't expect such a large amount of them. https://gerrit.wikimedia.org/r/538598 will also lower the logging level.

Makes sens,e thanks!