AbuseFilterVariableHolder::getVar: requested unset variable moved_from_namespace in strict mode, filter: 809
Closed, InvalidPublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	Urbanecm
	Oct 29 2019, 10:25 AM

Description

Error

MediaWiki version: 1.35.0-wmf.3

message

AbuseFilterVariableHolder::getVar: requested unset variable moved_from_namespace in strict mode, filter: 809

Impact

i'm not sure, filter can't process properly?

Notes

Logstash has 36m+ hits in last month, not sure since when it happens, since it timeouts on that search. See https://logstash.wikimedia.org/goto/968d6a889e2c8589b6274d276af68272 for more examples.

Details

Request ID: XbgS0gpAIDYAAAs01eQAAABS
Request URL: n/a

Stack Trace

exception.trace

n/a

Related Objects

Mentioned Here: T230256: Some abuse filters stopped matching after empty data introduction

Event Timeline

Urbanecm created this task.Oct 29 2019, 10:25 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2019, 10:25 AM

Urbanecm triaged this task as Unbreak Now! priority.Oct 29 2019, 10:25 AM

Restricted Application added subscribers: Daimona, Liuxinyu970226. · View Herald TranscriptOct 29 2019, 10:25 AM

Triaged as UBN, since it's possible it breaks affected filters.

That's just debug logging. It was introduced to see how many filters are affected by T230256. As you observed, there are *many* affected filters, hence T230256#5515823 will revert the change.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptOct 29 2019, 2:08 PM

In T236771#5615239, @Daimona wrote:

That's just debug logging. It was introduced to see how many filters are affected by T230256. As you observed, there are *many* affected filters, hence T230256#5515823 will revert the change.

Great. I still don't understand how T230256 can affect built-in variables like moved_from_namespace, but that might be just me not understanding the problem properly.

Maybe we should log such debug logging at debug/info (maybe even notice) severity, the warnings really frightened me :-).

In T236771#5623673, @Urbanecm wrote:

In T236771#5615239, @Daimona wrote:

That's just debug logging. It was introduced to see how many filters are affected by T230256. As you observed, there are *many* affected filters, hence T230256#5515823 will revert the change.

Great. I still don't understand how T230256 can affect built-in variables like moved_from_namespace

If the action being filtered is not a move, then moved_from_namespace isn't set.