Page MenuHomePhabricator

mediawiki/core/.pipeline/dev_prereq.sh: fails if VisualEditor lib/ve submodule is at a commit not present in shallow clone
Open, LowPublic

Description

Noticed while testing 547829: Exit on error for .pipeline/dev_prereq.sh:

Step 12/14 : RUN .pipeline/dev_prereq.sh
 ---> Running in 92dddee904be
Cloning into '/var/www/html/extensions/VisualEditor'...
Submodule 'lib/ve' (https://gerrit.wikimedia.org/r/VisualEditor/VisualEditor.git) registered for path 'lib/ve'
Cloning into '/var/www/html/extensions/VisualEditor/lib/ve'...
error: no such remote ref 8f850a718948833f5566db45d4c7f35614b78aba
Fetched in submodule path 'lib/ve', but it did not contain 8f850a718948833f5566db45d4c7f35614b78aba. Direct fetching of that commit failed.
Cloning into '/var/www/html/skins/Vector'...

Seems like there ought to be a way to get the right commit in the submodule. Some StackOverflow reading led me to:

git clone --depth 1 \
  --recursive \
  --shallow-submodules \
  https://gerrit.wikimedia.org/r/mediawiki/extensions/VisualEditor.git /var/www/html/extensions/VisualEditor

...but that doesn't quite seem to do the trick.

Event Timeline

brennen created this task.Nov 4 2019, 7:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2019, 7:58 PM
brennen updated the task description. (Show Details)Nov 4 2019, 7:59 PM

Change 547829 had a related patch set uploaded (by Jeena Huneidi; owner: Jeena Huneidi):
[mediawiki/core@master] Exit on error for .pipeline/dev_prereq.sh

https://gerrit.wikimedia.org/r/547829

Change 547829 merged by jenkins-bot:
[mediawiki/core@master] Exit on error for .pipeline/dev_prereq.sh

https://gerrit.wikimedia.org/r/547829

brennen triaged this task as Low priority.Jan 7 2020, 6:00 PM
brennen added a project: User-brennen.