Page MenuHomePhabricator

Fatal exception of type "InvalidArgumentException" on viewing diff of deleted revisions
Closed, DuplicatePublic

Description

When viewing diffs between deleted revisions, there is an exception raised. You only need to click on diff and the exception will occur.

I was finally able to reproduce this at test2wiki, where I'm able to see the stack trace.

However this occurs at dewiki as well, for example for me at:
https://de.wikipedia.org/w/index.php?title=Spezial:Wiederherstellen&target=Wikipedia%3ASchiedsgericht%2FAnfragen%2FSperrpr%C3%BCfung%3A+Mario+Schuller&timestamp=20191025002315&diff=prev (error ID for me: XcX9IgpAIEIAABErGcwAAAAC)

Or at https://de.wikipedia.org/wiki/Spezial:Wiederherstellen/Datei:Landesgartenschau_Alzenau.PNG (reported by Leyo, his error ID: XcXsKwpAAEAAAAXsByMAAAAU, original report: https://de.wikipedia.org/w/index.php?title=Wikipedia:Administratoren/Notizen&oldid=193883750#Fataler_Ausnahmefehler_des_Typs_%E2%80%9EInvalidArgumentException%E2%80%9C)

At test2wiki that can be seen here:

Details

Request ID
XcX@CgpAME8AAHujwBkAAACF
Request URL
https://test2.wikipedia.org/w/index.php?title=Special:Undelete&target=User%3ADCB%2FBTP%2FTeilnehmende&timestamp=20191105200953&diff=prev
Stack Trace

[XcX@CgpAME8AAHujwBkAAACF] /w/index.php?title=Special:Undelete&target=User%3ADCB%2FBTP%2FTeilnehmende&timestamp=20191105200953&diff=prev InvalidArgumentException from line 3275 of /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php: Revision 413629 doesn't belong to page 0

Backtrace:

#0 /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php(3482): MediaWiki\Revision\RevisionStore->assertRevisionParameter(string, integer, MediaWiki\Revision\RevisionArchiveRecord)
#1 /srv/mediawiki/php-1.35.0-wmf.5/includes/diff/DifferenceEngine.php(1552): MediaWiki\Revision\RevisionStore->countRevisionsBetween(integer, MediaWiki\Revision\RevisionArchiveRecord, MediaWiki\Revision\RevisionArchiveRecord, integer)
#2 /srv/mediawiki/php-1.35.0-wmf.5/includes/diff/DifferenceEngine.php(1052): DifferenceEngine->getMultiNotice()
#3 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialUndelete.php(583): DifferenceEngine->getDiff(string, string)
#4 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialUndelete.php(429): SpecialUndelete->showDiff(Revision, Revision)
#5 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialUndelete.php(204): SpecialUndelete->showRevision(string)
#6 /srv/mediawiki/php-1.35.0-wmf.5/includes/specialpage/SpecialPage.php(575): SpecialUndelete->execute(NULL)
#7 /srv/mediawiki/php-1.35.0-wmf.5/includes/specialpage/SpecialPageFactory.php(607): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(967): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(530): MediaWiki->main()
#11 /srv/mediawiki/php-1.35.0-wmf.5/index.php(46): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Nov 8, 11:46 PM
Luke081515 triaged this task as Unbreak Now! priority.Fri, Nov 8, 11:46 PM
Luke081515 changed the subtype of this task from "Task" to "Production Error".
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptFri, Nov 8, 11:46 PM
Luke081515 set Request URL to https://test2.wikipedia.org/w/index.php?title=Special:Undelete&target=User%3ADCB%2FBTP%2FTeilnehmende&timestamp=20191105200953&diff=prev.Fri, Nov 8, 11:47 PM
Luke081515 set Request ID to XcX@CgpAME8AAHujwBkAAACF.
Luke081515 updated the task description. (Show Details)
Luke081515 edited Stack Trace. (Show Details)
Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptSat, Nov 9, 4:52 AM
Raymond added a subscriber: Raymond.Sat, Nov 9, 4:23 PM