Page MenuHomePhabricator
Create Task
Maniphest T239505

When finding the latest application to renew, ignore denied applications
Closed, ResolvedPublic
Actions

Description

When a user has had a sent application, but then more recently had an application denied, they will see a server error when attempting to renew. Our logic for finding the latest application (to renew it) includes denied applications, which are not valid for renewal, causing an error. We should filter out denied applications when looking for the correct application.

Related Objects

Event Timeline

• AVasanth_WMF created this task.Nov 30 2019, 8:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2019, 8:43 AM
• AVasanth_WMF triaged this task as Medium priority.Nov 30 2019, 8:43 AM
• AVasanth_WMF moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.
• AVasanth_WMF updated the task description. (Show Details)
• AVasanth_WMF updated the task description. (Show Details)
• AVasanth_WMF mentioned this in T239504: Disallow a user from applying to the same partner more than once (except for partners with collections or specific_title).Nov 30 2019, 8:50 AM
• AVasanth_WMF updated the task description. (Show Details)Dec 1 2019, 12:36 PM
• AVasanth_WMF updated the task description. (Show Details)
Samwalton9-WMF subscribed.Dec 5 2019, 5:39 PM

Our logic for getting the latest application should look for the latest Sent application, not just the latest app, when renewing. In this way if a more recent application was declined, we still allow users to submit valid renewal applications.

Nikkimaria added a parent task: T240153: Address project technical debt.Dec 8 2019, 9:41 PM
Samwalton9-WMF renamed this task from Investigate what can be done when users want to apply (or renew?) again when their previous application was declined (`NOT_APPROVED`) to When finding the latest application to renew, ignore denied applications.Jan 6 2020, 9:46 AM
Samwalton9-WMF raised the priority of this task from Medium to High.
Samwalton9-WMF updated the task description. (Show Details)

This is causing a renewal problem for someone.

• AVasanth_WMF claimed this task.Jan 6 2020, 11:14 AM
• AVasanth_WMF moved this task from Open tasks to Planned on the Library-Card-Platform board.
• AVasanth_WMF moved this task from Planned to Done on the Library-Card-Platform board.Jan 7 2020, 2:32 PM

https://github.com/WikipediaLibrary/TWLight/pull/386

• AVasanth_WMF closed this task as Resolved.Jan 23 2020, 6:15 AM
Samwalton9-WMF removed a subtask: T239507: Provide more information on a user's previous applications for the coordinators on the Application Evaluation page.Feb 13 2020, 5:33 PM
Samwalton9-WMF removed a parent task: T240153: Address project technical debt.Jun 25 2020, 5:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL