Page MenuHomePhabricator

Graph x axes should end at the filtered end date instead of always the present day
Closed, ResolvedPublic

Description

If you set the end date on an organisation or program page to a date before the present day, the graph x axis still runs all the way to today's date, simply showing zero for data between the end date and now.

image.png (967×1 px, 80 KB)

Instead, the x axis should span from the earliest data (or the start date) to the end date, and no further.

Acceptance criteria

  • When an end date is set on an Organisation or Program page, the link events graph should only run as far as that date.

Event Timeline

Samwalton9-WMF renamed this task from Graphs start at the current day regardless of date filtering to Graph x axes end at the present day regardless of date filtering.Jul 8 2020, 10:31 AM
Samwalton9-WMF updated the task description. (Show Details)
Samwalton9-WMF renamed this task from Graph x axes end at the present day regardless of date filtering to Graph x axes should end at the filtered end date instead of always the present day.Jul 14 2020, 2:50 PM
Samwalton9-WMF moved this task from Ready to Done on the The-Wikipedia-Library (Kanban) board.

We just merged some changes to the tool and it turns out this is actually fixed now, probably in https://github.com/WikipediaLibrary/externallinks/pull/55.

Okay, then, I will find some other bugs to fix!