Cleaner and simpler
Description
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Declined | DannyS712 | T236632 [Tracking] Newsletter | |||
Resolved | DannyS712 | T239450 84: Newsletter, issue #4 | |||
Resolved | DannyS712 | T239739 88: Convert settings toggles to checkboxes |
Event Timeline
Comment Actions
Do you want to try to do this?
- Expand the inputs for GlobalWatchlist.OOUI.checkBox to not rely on the checkbox representing a filter (i.e. actually pass id, label, and selected as params) and likewise update the callers
- Update GlobalWatchlist.OOUI.resetCheckBox to not rely on the checkbox representing a filter (i.e. actually pass id and selected as params) and likewise update the callers
- Convert current callers of GlobalWatchlist.OOUI.toggleSwitchE to use the new checkBox:
- Currently, the toggle and the label are separate, this will combine them into the same call to create the checkBox
- Replace calls to GlobalWatchlist.OOUI.resetToggleSwitch with the updated resetCheckBox
- Remove resetToggleSwitch and toggleSwitchE methods
Comment Actions
As Volker_E said in T236176#5627403,
ToggleSwitches should only be used in settings where instant effect is possible.
So checkbox seems to be a plausible alternative.
Comment Actions
Nah, I am not really familiar with OOUI input widget and this is too complicated for me. (: