Page MenuHomePhabricator

Wikilinks containing dollar sign $ are not linked on Wikimedia Bugzilla
Closed, ResolvedPublic

Details

Reference
bz21984

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:49 PM
bzimport set Reference to bz21984.
bzimport added a subscriber: Unknown Object (MLST).

Also in bug 21985. That dollar sign seems to be the problem.

[[mw:Manual:$wgForeignFileRepos]] and [[Manual:$wgForeignFileRepos]] and [[mw:$wgForeignFileRepos]] are all tests.

In theory, r86427 was supposed to fix this. Did it ever get deployed?

(Well someone is doing this, it'd be awesome if someone could denote mw as an internal interwiki prefix, so such links actually work... There really is no reason not to have it as an internal prefix. But thats another bug somewhere)

yeah, doesn't look like it was deployed. Priyanka, if you haven't deployed, please do.

content hidden as private in Bugzilla

(In reply to comment #4)

In theory, r86427 was supposed to fix this. Did it ever get deployed?

r86427 fixed [[%]] (bug 5268), but not [[$]] (this bug).

Looks like [[%]] was there before r86427, though. Looking at the diff and these two bugs, I'm confused about what fixes what.

(In reply to comment #7)

(In reply to comment #4)

In theory, r86427 was supposed to fix this. Did it ever get deployed?

r86427 fixed [[%]] (bug 5268), but not [[$]] (this bug).

That bug isn't fixed. The bug was requesting that a lone % be url encoded into %25 instead of just being a raw % (and if you look at the url, [[%]] is still an invalid url). %'s were always linked as far as I can tell. (However with that said, I'm also unclear how r86427 has anything to do with that issue)

pdhanda wrote:

Bugmeister is the new Bugzilla maintainer and default assignee.

Thehelpfulonewiki wrote:

Reset assignee per bug 37789

I'm confused - URLs in bug 21985 link correctly nowadays. Plus comment 9 is about % but the bug summary is about $.

Could somebody provide a testcase, expected outcome, and describe current outcome?

(In reply to comment #12)

I'm confused - URLs in bug 21985 link correctly nowadays. Plus comment 9 is
about % but the bug summary is about $.

Could somebody provide a testcase, expected outcome, and describe current
outcome?

Presumably fixed. Comments are rendered at view time, once the bug is fixed, all old examples in comments are also fixed.