EntityInitializer: remove work-around for incorrect empty object serialization
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Dec 13 2019, 12:37 PM

Description

Wikibase had a problem T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []. The problem can now be overcome through a configuration, yet the default wikibase configuration still shows the old behavior.

Termbox's EntityInitializer contains a workaround for the old behavior.
Remove the workaround from EntityInitializer as soon as wikibase behaves in a safe way by default.

Related Objects

Mentioned In: rWBTB85fbc40143a8: EntityInitializer: unlearn fix for poor serialization
Mentioned Here: T138104: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array []

Event Timeline

• Pablo-WMDE created this task.Dec 13 2019, 12:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2019, 12:37 PM

Change 555937 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] EntityInitializer: unlearn fix for poor serialization

https://gerrit.wikimedia.org/r/555937

gerritbot added a project: Patch-For-Review.Dec 13 2019, 12:39 PM

• Pablo-WMDE added a project: User-Pablo-WMDE.Nov 18 2020, 9:01 AM

• Pablo-WMDE moved this task from Incoming to Short term on the User-Pablo-WMDE board.

I'm fairly sure this is good to go but can't take this on anymore.

Change 555937 abandoned by Addshore:
[wikibase/termbox@master] EntityInitializer: unlearn fix for poor serialization

Reason:
Abandoning old outdated things from 2019

https://gerrit.wikimedia.org/r/555937

wiese added a subscriber: Lucas_Werkmeister_WMDE.Mar 10 2021, 11:37 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2021, 9:58 AM

Change 555937 restored by Tonina Zhelyazkova:

[wikibase/termbox@master] EntityInitializer: unlearn fix for poor serialization