SecureLinkFixer: Add check that domains.php is exactly what should have been generated
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Dec 29 2019, 12:09 AM

Description

domains.php is reproducible in theory, we should verify that. This also protects against the bot doing some kind of code injection in the file.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add a test verifying the reproducibility of domains.php	mediawiki/extensions/SecureLinkFixer	master	+11 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T239005 SLF bot should have +2 rights and automatically merge own patches
		Resolved		Legoktm	T241522 SecureLinkFixer: Add check that domains.php is exactly what should have been generated

Event Timeline

Legoktm created this task.Dec 29 2019, 12:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2019, 12:09 AM

Change 560960 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SecureLinkFixer@master] Add a test verifying the reproducibility of domains.php

https://gerrit.wikimedia.org/r/560960

gerritbot added a project: Patch-For-Review.Dec 29 2019, 1:21 AM

Change 560960 merged by jenkins-bot:
[mediawiki/extensions/SecureLinkFixer@master] Add a test verifying the reproducibility of domains.php

https://gerrit.wikimedia.org/r/560960

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 10 2020, 6:01 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 10 2020, 6:10 PM

Legoktm closed this task as Resolved.Feb 10 2020, 7:11 PM