Page MenuHomePhabricator

History table formatting looks naff in Bugzilla (Table has no CSS styling)
Closed, DeclinedPublic

Description

https://bugzilla.wikimedia.org/show_activity.cgi?id=148

Looks a bit naff by default, and then the empty cells are just white


Version: unspecified
Severity: minor

Details

Reference
bz22166

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:49 PM
bzimport set Reference to bz22166.
bzimport added a subscriber: Unknown Object (MLST).

Looks better without the borders.. But it's hard to read... :)

  • This bug has been marked as a duplicate of bug 22200 ***

Reopened, dupped in the wrong direction.

  • Bug 22200 has been marked as a duplicate of this bug. ***

This was done in the last major bz update.

Reopened, we lost the styling again.

pdhanda wrote:

Bugmeister is the new Bugzilla maintainer and default assignee.

Thehelpfulonewiki wrote:

Reset assignee per bug 37789

My guess is something like <table border cellpadding="4"> in
/template/en/default/bug/activity/table.html.tmpl

Guess only, because looking at
http://svn.wikimedia.org/viewvc/mediawiki/trunk/tools/bugzilla/bugzilla-4.0/ there seems to be only custom stuff hosted.
Cannot find any Bugzilla code in Git/Gerrit after going through https://gerrit.wikimedia.org/r/#/admin/projects/

Ignore comment 9.

Happens due to our custom vector.css in https://git.wikimedia.org/blob/wikimedia%2Fbugzilla%2Fmodifications.git/HEAD/skins%2Fcontrib%2FWikimedia%2Fvector.css :

#bodyContent table {
font-size: 100%;
border: none;
}

Need to test on boogs.wmflabs.org if removing that line has much effect on other tables. As vector.css is a big mystery to me.

Same reason why the table on https://bugzilla.wikimedia.org/userprefs.cgi?tab=saved-searches does not have any borders.

I played a bit on boogs.wmflabs.org:

Deleting

#bodyContent table {
    font-size: 100%;
    border: none;
}
#bodyContent td, #bodyContent th {
    border: medium none;
}

from vector.css fixes this problem, but then the tabs at the top of http://boogs.wmflabs.org/userprefs.cgi?tab=saved-searches have ugly fat lines.

This might be fixed by adding

border: medium none;

to the definition of ".tabs td" in vector.css.

Wikimedia has migrated from Bugzilla to Phabricator. Learn more about it here: https://www.mediawiki.org/wiki/Phabricator/versus_Bugzilla - This task does not make sense anymore in the concept of Phabricator, hence closing as declined.