Page MenuHomePhabricator

invalid dependency check causes silent failure
Closed, ResolvedPublic


in the summaryCard function, there is this

if ( !defined( 'TEXT_EXTRACTS_INSTALLED') ) {
        wfDebugLog( 'TwitterCards', 'TextExtracts extension is missing for summary card.' );

The TextExtracts extension does not define such a GLOBAL and therefore the function exits while emitting an entry into the debug log

Related Objects

Event Timeline

Product Version
MediaWiki 1.32.6 (5807cdf)
06:31, 19 December 2019
PHP 7.1.33-3+0~20191218.29+debian9~1.gbp18b07c (apache2handler)
MariaDB 10.1.41-MariaDB-0+deb9u1
ICU 64.1
Elasticsearch 5.6.16
Lua 5.1.5

Change 566358 had a related patch set uploaded (by Freephile; owner: Freephile):
[mediawiki/extensions/TwitterCards@master] Remove invalid Dependency check

Change 566519 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[integration/config@master] Add TextExtracts as dependency for SpellingDictionary

Change 566519 merged by jenkins-bot:
[integration/config@master] Add TextExtracts as dependency for TwitterCards

Mentioned in SAL (#wikimedia-releng) [2020-01-22T20:19:33Z] <James_F> Zuul: Adding TextExtracts as a dependency for TwitterCards T242171

Change 566358 merged by jenkins-bot:
[mediawiki/extensions/TwitterCards@master] Remove invalid Dependency check

By the looks of it, all patches related to this issue have been merged. I believe this task is complete.