Page MenuHomePhabricator

invalid dependency check causes silent failure
Open, Needs TriagePublic

Description

in the summaryCard function, there is this

if ( !defined( 'TEXT_EXTRACTS_INSTALLED') ) {
        wfDebugLog( 'TwitterCards', 'TextExtracts extension is missing for summary card.' );
        return;
}

The TextExtracts extension does not define such a GLOBAL and therefore the function exits while emitting an entry into the debug log

Details

Related Gerrit Patches:
mediawiki/extensions/TwitterCards : masterRemove invalid Dependency check
integration/config : masterparameter_functions.py: Add TextExtracts as dependency for TwitterCards

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2020, 10:45 PM

Product Version
MediaWiki 1.32.6 (5807cdf)
06:31, 19 December 2019
PHP 7.1.33-3+0~20191218.29+debian9~1.gbp18b07c (apache2handler)
MariaDB 10.1.41-MariaDB-0+deb9u1
ICU 64.1
Elasticsearch 5.6.16
Lua 5.1.5

Change 566358 had a related patch set uploaded (by Freephile; owner: Freephile):
[mediawiki/extensions/TwitterCards@master] Remove invalid Dependency check

https://gerrit.wikimedia.org/r/566358

Change 566519 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[integration/config@master] parameter_functions.py: Add TextExtracts as dependency for SpellingDictionary

https://gerrit.wikimedia.org/r/566519

Change 566519 merged by jenkins-bot:
[integration/config@master] parameter_functions.py: Add TextExtracts as dependency for TwitterCards

https://gerrit.wikimedia.org/r/566519

Mentioned in SAL (#wikimedia-releng) [2020-01-22T20:19:33Z] <James_F> Zuul: Adding TextExtracts as a dependency for TwitterCards T242171

Change 566358 merged by jenkins-bot:
[mediawiki/extensions/TwitterCards@master] Remove invalid Dependency check

https://gerrit.wikimedia.org/r/566358