Page MenuHomePhabricator

Extend flow_ext_ref.ref_src_wiki
Closed, ResolvedPublic

Description

Basically the same as T241387

What:

ALTER TABLE /*_*/flow_ext_ref MODIFY ref_src_wiki varchar(64) binary not null;

Where: Everywhere that has the flow_ext_ref table. private wikis have it as part of their database. everywhere else is extension1/flowdb

When: At DBA's leisure (patch is merged, no code dependancy)

Is backwards compatible: Yes

Has been tested already: CI merging

Schema change progress:

s3:

  • officewiki
  • techconductwiki

x1

  • flowdb

s10

  • labswiki

Event Timeline

Reedy created this task.Mon, Jan 13, 11:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Jan 13, 11:47 PM
Marostegui triaged this task as Medium priority.
Marostegui moved this task from Triage to In progress on the DBA board.
Marostegui moved this task from Backlog to In progress on the Blocked-on-schema-change board.

Mentioned in SAL (#wikimedia-operations) [2020-01-14T06:20:03Z] <marostegui> Deploy schema change on s3 master for officewiki and techconductwiki T242688

officewiki
*************************** 1. row ***************************
       Table: flow_ext_ref
Create Table: CREATE TABLE `flow_ext_ref` (
  `ref_src_object_id` binary(11) NOT NULL,
  `ref_src_object_type` varbinary(32) NOT NULL,
  `ref_src_workflow_id` binary(11) NOT NULL,
  `ref_src_namespace` int(11) NOT NULL,
  `ref_src_title` varbinary(255) NOT NULL,
  `ref_target` blob NOT NULL,
  `ref_type` varbinary(16) NOT NULL,
  `ref_src_wiki` varbinary(64) NOT NULL,
  `ref_id` binary(11) NOT NULL,
  PRIMARY KEY (`ref_id`),
  KEY `flow_ext_ref_idx_v2` (`ref_src_wiki`,`ref_src_namespace`,`ref_src_title`,`ref_type`,`ref_target`(255),`ref_src_object_type`,`ref_src_object_id`),
  KEY `flow_ext_ref_revision_v2` (`ref_src_wiki`,`ref_src_namespace`,`ref_src_title`,`ref_src_object_type`,`ref_src_object_id`,`ref_type`,`ref_target`(255))
) ENGINE=InnoDB DEFAULT CHARSET=binary
techconductwiki
*************************** 1. row ***************************
       Table: flow_ext_ref
Create Table: CREATE TABLE `flow_ext_ref` (
  `ref_id` binary(11) NOT NULL,
  `ref_src_wiki` varbinary(64) NOT NULL,
  `ref_src_object_id` binary(11) NOT NULL,
  `ref_src_object_type` varbinary(32) NOT NULL,
  `ref_src_workflow_id` binary(11) NOT NULL,
  `ref_src_namespace` int(11) NOT NULL,
  `ref_src_title` varbinary(255) NOT NULL,
  `ref_target` blob NOT NULL,
  `ref_type` varbinary(16) NOT NULL,
  PRIMARY KEY (`ref_id`),
  KEY `flow_ext_ref_idx_v3` (`ref_src_wiki`,`ref_src_namespace`,`ref_src_title`,`ref_type`,`ref_target`(255),`ref_src_object_type`,`ref_src_object_id`),
  KEY `flow_ext_ref_revision_v2` (`ref_src_wiki`,`ref_src_namespace`,`ref_src_title`,`ref_src_object_type`,`ref_src_object_id`,`ref_type`,`ref_target`(255))
) ENGINE=InnoDB DEFAULT CHARSET=binary
Marostegui updated the task description. (Show Details)Tue, Jan 14, 6:22 AM

Mentioned in SAL (#wikimedia-operations) [2020-01-14T06:23:22Z] <marostegui> Deploy schema change on labswiki (wikitech) T242688

Marostegui updated the task description. (Show Details)Tue, Jan 14, 6:23 AM

Mentioned in SAL (#wikimedia-operations) [2020-01-14T06:25:48Z] <marostegui> Deploy schema change on flowdb (x1) directly on the master T242688

Marostegui closed this task as Resolved.Tue, Jan 14, 6:26 AM
Marostegui updated the task description. (Show Details)

All done!