Page MenuHomePhabricator
Create Task
Maniphest T246178

Watchlist_Settings: Settings control must have a label
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Navigate to main page
  2. Navigate till "Watchlist" control on upper right corner and hit enter.
  3. Navigate till "Changes Limit/Date" control and hit enter.
  4. Verify using accessibility insights tool (https://accessibilityinsights.io/)

Actual Results:
Settings button and select widgets in the popup are not accessible

Expected Results:
Settings button and select widgets in the popup must be accessible

Details

SubjectRepoBranchLines +/-
RCFilters: Add a11y label to buttons for filtering by changes and daysmediawiki/coremaster+4 -0
Customize query in gerrit

Event Timeline

Akinwale-microsoft created this task.Feb 25 2020, 11:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2020, 11:29 PM
gerritbot added a comment.Feb 25 2020, 11:29 PM

Change 574865 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[mediawiki/core@master] Fix: Filter by changes and days button accessibility Screen reader just announces x changes, y days, it doesn't announce the meaning of the button We added an aria-label property to the button to make it accessible to visually impaired audiences

https://gerrit.wikimedia.org/r/574865

gerritbot added a project: Patch-For-Review.Feb 25 2020, 11:29 PM
Akinwale-microsoft edited projects, added MediaWiki-Watchlist; removed MediaWiki-General.Feb 25 2020, 11:32 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 25 2020, 11:32 PM
Akinwale-microsoft updated the task description. (Show Details)Feb 25 2020, 11:36 PM
Tam-edwin-microsoft updated the task description. (Show Details)Jul 5 2020, 4:27 AM
gerritbot added a comment.Jul 6 2020, 7:20 PM

Change 574865 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Add a11y label to buttons for filtering by changes and days

https://gerrit.wikimedia.org/r/574865

matmarex closed this task as Resolved.Jul 6 2020, 7:26 PM
matmarex removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 6 2020, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits