Page MenuHomePhabricator
Create Task
Maniphest T247500

Map is offset in fullscreen after closing the sidebar
Closed, ResolvedPublic
Actions

Description

initial:

Screenshot 2020-03-12 at 11.09.56.png (1×1 px, 632 KB)

open sidebar:
Screenshot 2020-03-12 at 11.10.03.png (1×1 px, 578 KB)

close sidebar:
Screenshot 2020-03-12 at 11.10.11.png (1×1 px, 610 KB)

This is caused by the sidebar having some 'left over' size after hiding it, which is pushing the map up.
Initially, the sidebar isn't loaded in the DOM so that is why you don't see this problem on 1st load.

Details

SubjectRepoBranchLines +/-
Fix offset after closing sidebar in fullscreenmediawiki/extensions/Kartographermaster+7 -3
Customize query in gerrit

Event Timeline

TheDJ created this task.Mar 12 2020, 10:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2020, 10:13 AM
TheDJ claimed this task.Mar 12 2020, 10:13 AM
TheDJ triaged this task as Low priority.
TheDJ added a project: Maps (Kartographer).
gerritbot added a comment.Mar 12 2020, 10:13 AM

Change 579099 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/Kartographer@master] Fix offset after closing sidebar in fullscreen

https://gerrit.wikimedia.org/r/579099

gerritbot added a project: Patch-For-Review.Mar 12 2020, 10:13 AM
gerritbot added a comment.Mar 12 2020, 10:16 PM

Change 579099 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Fix offset after closing sidebar in fullscreen

https://gerrit.wikimedia.org/r/579099

Jdforrester-WMF closed this task as Resolved.Mar 12 2020, 10:21 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 12 2020, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 12 2020, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits