| Volker_E | |
| Mar 17 2020, 8:59 PM |
| F31687834: image.png | |
| Mar 17 2020, 8:59 PM |
Currently ref code fails to fulfill contrast ratio due to its slight gray background:
We need to amend this to #d73333 similar to OOUI's destructive ButtonWidget
Actually, that probably leads to more issues in other themes, let's stick with background-color: transparent here to also eye possible dark or other themes.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix cite error ref code color contrast ratio | mediawiki/extensions/Cite | master | +3 -0 |
Change 580481 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Cite@master] Fix cite error ref code color contrast ratio
Note it was just recently that we changed the color of <code> elements in error messages: https://gerrit.wikimedia.org/r/559714. Before, a <code> element would appear black on gray, in the middle of a red error message, which made it look like it is not part of the error message. If this change was a mistake and you believe <code> should look black again, please tell us.
Change 580481 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Fix cite error ref code color contrast ratio