Page MenuHomePhabricator

Unit tests of OpenStackManager extension failing with php7.4
Closed, ResolvedPublic

Description

04:57:02 There were 2 errors:
04:57:02 
04:57:02 1) SpecialPageFatalTest::testSpecialPageDoesNotFatal with data set "Preferences" (SpecialPreferences Object (...))
04:57:02 === Logs generated by test case
04:57:02 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
04:57:02 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
04:57:02 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
04:57:02 [wfDebug] [debug] User: loading options for user 1 from database. {"private":false}
04:57:02 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
04:57:02 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
04:57:02 [Parser] [debug] Parser::setOutputFlag: set user-signature flag on 'Special:Preferences'; User signature detected []
04:57:02 [GlobalTitleFail] [info] MessageCache::parse called with no title set. {"exception":{}}
04:57:02 ===
04:57:02 Trying to access array offset on value of type null
04:57:02 
04:57:02 /workspace/src/extensions/OpenStackManager/includes/OpenStackNovaUser.php:55
04:57:02 /workspace/src/extensions/OpenStackManager/includes/OpenStackNovaUser.php:21
04:57:02 /workspace/src/extensions/OpenStackManager/includes/OpenStackNovaUser.php:366
04:57:02 /workspace/src/includes/Hooks.php:174
04:57:02 /workspace/src/includes/Hooks.php:202
04:57:02 /workspace/src/includes/preferences/DefaultPreferencesFactory.php:203
04:57:02 /workspace/src/includes/preferences/DefaultPreferencesFactory.php:1560
04:57:02 /workspace/src/includes/specials/SpecialPreferences.php:113
04:57:02 /workspace/src/includes/specials/SpecialPreferences.php:90
04:57:02 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:108
04:57:02 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
04:57:02 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php:33
04:57:02 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
04:57:02 /workspace/src/maintenance/doMaintenance.php:99
04:57:02 
04:57:02 2) SpecialPageFatalTest::testSpecialPageDoesNotFatal with data set "NovaKey" (SpecialNovaKey Object (...))
04:57:02 === Logs generated by test case
04:57:02 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
04:57:02 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
04:57:02 [wfDebug] [debug] User: cache miss for user 1 {"private":false}
04:57:02 [wfDebug] [debug] User: loading options for user 1 from database. {"private":false}
04:57:02 [objectcache] [debug] fetchOrRegenerate(global:user:id:wikidb-unittest_:1): miss, new value computed []
04:57:02 ===
04:57:02 Trying to access array offset on value of type null
04:57:02 
04:57:02 /workspace/src/extensions/OpenStackManager/includes/OpenStackNovaUser.php:55
04:57:02 /workspace/src/extensions/OpenStackManager/includes/OpenStackNovaUser.php:21
04:57:02 /workspace/src/extensions/OpenStackManager/includes/SpecialNovaKey.php:23
04:57:02 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:108
04:57:02 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:36
04:57:02 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php:33
04:57:02 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
04:57:02 /workspace/src/maintenance/doMaintenance.php:99
04:57:02 
04:57:02 ERRORS!

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/55/console

Event Timeline

Change 582497 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/OpenStackManager@master] Avoid access array offset on value of type null on php7.4

https://gerrit.wikimedia.org/r/582497

Change 582497 merged by jenkins-bot:
[mediawiki/extensions/OpenStackManager@master] Avoid access array offset on value of type null on php7.4

https://gerrit.wikimedia.org/r/582497

Umherirrender claimed this task.
Umherirrender triaged this task as Medium priority.