Page MenuHomePhabricator

Remove cgi_interface because it is dysfunctional
Closed, ResolvedPublic

Description

C:\pwb\GIT\core>py -3 pwb.py touch
ERROR: Unable to execute script because no generator was defined.
Use -help for further information.

C:\pwb\GIT\core>py -3 pwb.py touch
Traceback (most recent call last):
  File "pwb.py", line 204, in <module>
    import pywikibot as pwb
  File "C:\pwb\GIT\core\pywikibot\__init__.py", line 25, in <module>
    from pywikibot.bot import (
  File "C:\pwb\GIT\core\pywikibot\bot.py", line 154, in <module>
    pywikibot.argvu = ui.argvu()
AttributeError: 'UI' object has no attribute 'argvu'

C:\pwb\GIT\core>

In compat we had several user interfaces:

  • terminal_interface
  • tkinter_interface
  • wxpython_interface
  • cgi_interface

But tkinter and wxpython where removed seven years ago because they didn't work correctly:
https://mediawiki.org/wiki/Special:Code/pywikipedia/11620

The cgi interface is also dysfunctional. Its interface, attributes and methods do not match the usual terminal interface an must be rewritten if the interface should become a useful interface. I don't think that it ever worked. I propose to remove it.

Event Timeline

Xqt created this task.Mar 23 2020, 6:44 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMar 23 2020, 6:44 AM
Xqt updated the task description. (Show Details)

Change 483764 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Remove disfunctional cgi_interface.py

https://gerrit.wikimedia.org/r/483764

JJMC89 renamed this task from cgi_interface is disfunctional to Remove cgi_interface because it is dysfunctional.Mar 23 2020, 7:00 AM
JJMC89 updated the task description. (Show Details)
JJMC89 awarded a token.

Change 483764 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Remove disfunctional cgi_interface.py

https://gerrit.wikimedia.org/r/483764

Xqt closed this task as Resolved.Mar 23 2020, 11:08 AM
Xqt claimed this task.