Page MenuHomePhabricator

Top and bottom borders for the alias pills in the TemplateData editor are cut off
Closed, ResolvedPublic

Description

Steps to reproduce:

Expected:

  • In the list of "Template parameters", the alias pills on the right ("name, "nativename", etc) should have a complete border all the way around the text.

Actual:

  • The top and bottom borders are cut off:

Solution:

This could be solved by adding a 1px padding to the containing div, which has class tdg-templateDataParamWidget-param-aliases.

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 25 2020, 3:47 PM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript

Change 583955 had a related patch set uploaded (by AdhamKhatean; owner: AdhamKhatean):
[mediawiki/extensions/TemplateData@master] Fix borders for alias pills in TemplateData editor

https://gerrit.wikimedia.org/r/583955

Change 583955 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Fix borders for alias pills in TemplateData editor

https://gerrit.wikimedia.org/r/583955

Tchanders closed this task as Resolved.Mar 30 2020, 4:06 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 30 2020, 4:06 PM