Page MenuHomePhabricator
Create Task
Maniphest T249082

Remove calls to wfSetupSession()
Closed, ResolvedPublic
Actions

Description

wfSetupSession() has been hard deprecated and is slated for removal before MW 1.35 release. It still have callers though.

Details

SubjectRepoBranchLines +/-
Avoid usage of deprecated wfSetupSession()mediawiki/skins/WPtouchmaster+3 -6
Avoid usage of deprecated wfSetupSession()mediawiki/extensions/SocialLoginmaster+2 -3
Avoid usage of deprecated wfSetupSession();mediawiki/extensions/LdapAuthenticationmaster+7 -2
Remove usage of deprecated wfSetupSession()mediawiki/extensions/AzharAuthmaster+1 -1
Remove usage of deprecated wfSetupSession()mediawiki/extensions/OpenIDmaster+3 -11
Avoid usage of deprecated wfSetupSession()mediawiki/extensions/OpenIDConnectmaster+2 -3
Avoid usage of deprecated wfSetupSession();mediawiki/extensions/WikiForummaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

Ammarpad created this task.Apr 1 2020, 6:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 6:54 AM
Ammarpad updated the task description. (Show Details)Apr 1 2020, 8:44 AM
gerritbot added a comment.Apr 1 2020, 9:27 AM

Change 585182 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/LdapAuthentication@master] Avoid usage of deprecated wfSetupSession();

https://gerrit.wikimedia.org/r/585182

gerritbot added a project: Patch-For-Review.Apr 1 2020, 9:27 AM
gerritbot added a comment.Apr 1 2020, 9:58 AM

Change 585184 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/OpenID@master] Remove usage of deprecated wfSetupSession()

https://gerrit.wikimedia.org/r/585184

gerritbot added a comment.Apr 1 2020, 10:20 AM

Change 585189 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/SocialLogin@master] Avoid usage of deprecated wfSetupSession()

https://gerrit.wikimedia.org/r/585189

gerritbot added a comment.Apr 1 2020, 10:25 AM

Change 585192 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/OpenIDConnect@master] Avoid usage of deprecated wfSetupSession()

https://gerrit.wikimedia.org/r/585192

Ammarpad mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.Apr 1 2020, 10:28 AM
gerritbot added a comment.Apr 1 2020, 10:43 AM

Change 585193 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/WikiForum@master] Avoid usage of deprecated wfSetupSession();

https://gerrit.wikimedia.org/r/585193

Aklapper added projects: MediaWiki-extensions-SocialLogin, MediaWiki-extensions-OpenID, MediaWiki-extensions-LdapAuthentication, MediaWiki-extensions-Other.Apr 1 2020, 10:44 AM

(For the records, the SocialLogin patch might get declined due to T246273)

gerritbot added a comment.Apr 1 2020, 11:01 AM

Change 585196 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/AzharAuth@master] Remove usage of deprecated wfSetupSession()

https://gerrit.wikimedia.org/r/585196

gerritbot added a comment.Apr 6 2020, 10:16 AM

Change 585193 merged by jenkins-bot:
[mediawiki/extensions/WikiForum@master] Avoid usage of deprecated wfSetupSession();

https://gerrit.wikimedia.org/r/585193

gerritbot added a comment.Apr 12 2020, 7:15 PM

Change 585192 merged by jenkins-bot:
[mediawiki/extensions/OpenIDConnect@master] Avoid usage of deprecated wfSetupSession()

https://gerrit.wikimedia.org/r/585192

gerritbot added a comment.May 1 2020, 4:39 PM

Change 585184 merged by jenkins-bot:
[mediawiki/extensions/OpenID@master] Remove usage of deprecated wfSetupSession()

https://gerrit.wikimedia.org/r/585184

gerritbot added a comment.May 1 2020, 4:39 PM

Change 585196 merged by jenkins-bot:
[mediawiki/extensions/AzharAuth@master] Remove usage of deprecated wfSetupSession()

https://gerrit.wikimedia.org/r/585196

gerritbot added a comment.May 1 2020, 4:40 PM

Change 585182 merged by jenkins-bot:
[mediawiki/extensions/LdapAuthentication@master] Avoid usage of deprecated wfSetupSession();

https://gerrit.wikimedia.org/r/585182

gerritbot added a comment.May 1 2020, 4:45 PM

Change 585189 merged by Jforrester:
[mediawiki/extensions/SocialLogin@master] Avoid usage of deprecated wfSetupSession()

https://gerrit.wikimedia.org/r/585189

Jdforrester-WMF closed this task as Resolved.May 1 2020, 4:57 PM
Jdforrester-WMF assigned this task to Ammarpad.
Maintenance_bot removed a project: Patch-For-Review.May 1 2020, 5:10 PM
gerritbot added a comment.May 1 2020, 5:42 PM

Change 593773 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/skins/WPtouch@master] Avoid usage of deprecated wfSetupSession()

https://gerrit.wikimedia.org/r/593773

gerritbot added a project: Patch-For-Review.May 1 2020, 5:42 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).May 1 2020, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL