Page MenuHomePhabricator
Create Task
Maniphest T249283

Remove watchlist expired items from WatchedItemStore clearUserWatchedItems method
Closed, ResolvedPublic
Actions

Description

The class WatchedItemStore has a function clearUserWatchedItems that is used to removed a user's watched items from the store by deleting related rows from watchlist table. The function needs to delete the items from the watchlist_expiry table as well.

Details

SubjectRepoBranchLines +/-
Remove expired items in WatchedItemStore::clearUserWatchedItemsmediawiki/coremaster+74 -6
Customize query in gerrit

Related Objects

Event Timeline

HMonroy created this task.Apr 2 2020, 9:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2020, 9:47 PM
HMonroy added a project: Expiring-Watchlist-Items.Apr 2 2020, 9:49 PM
Restricted Application added projects: TCB-Team (now WMDE-TechWish), Community-Tech. · View Herald TranscriptApr 2 2020, 9:49 PM
HMonroy edited projects, added Community-Tech (Kanban-2019-20-Q4); removed Community-Tech.Apr 2 2020, 9:50 PM
HMonroy moved this task from Ready to In Development on the Community-Tech (Kanban-2019-20-Q4) board.
HMonroy removed a subscriber: Community-Tech (Kanban-2019-20-Q4).
gerritbot added a comment.Apr 8 2020, 2:47 AM

Change 587394 had a related patch set uploaded (by HMonroy; owner: HMonroy):
[mediawiki/core@master] Remove expired items in WatchedItemStore::clearUserWatchedItems

https://gerrit.wikimedia.org/r/587394

gerritbot added a project: Patch-For-Review.Apr 8 2020, 2:47 AM
HMonroy moved this task from In Development to Needs Review/Feedback on the Community-Tech (Kanban-2019-20-Q4) board.Apr 8 2020, 2:48 AM
gerritbot added a comment.Apr 9 2020, 12:50 AM

Change 587394 merged by jenkins-bot:
[mediawiki/core@master] Remove expired items in WatchedItemStore::clearUserWatchedItems

https://gerrit.wikimedia.org/r/587394

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 9 2020, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 9 2020, 1:10 AM
HMonroy moved this task from Needs Review/Feedback to QA on the Community-Tech (Kanban-2019-20-Q4) board.Apr 13 2020, 4:34 PM
dom_walden moved this task from QA to Product sign-off on the Community-Tech (Kanban-2019-20-Q4) board.Apr 27 2020, 2:21 PM
dom_walden subscribed.

Examining the code, this change only affects (@HMonroy correct me if I am wrong):

  • EditWatchlist/clear
  • EditWatchlist/raw

Both of which have been tested recently in T245224.

HMonroy added a comment.Apr 27 2020, 5:39 PM

@dom_walden This code only affects a test in WatchedItemStoreIntegrationTest.php (https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/097c6b575d44848f6531a84c5556a7ca2ab507a7/tests/phpunit/includes/watcheditem/WatchedItemStoreIntegrationTest.php#198).

EditWatchlist/clear and EditWatchlist/raw have their own clearUserWatchedItems function, which was indeed tested in T245224

ifried closed this task as Resolved.Jun 10 2020, 1:12 AM
ifried moved this task from Product sign-off to Done on the Community-Tech (Kanban-2019-20-Q4) board.
ifried subscribed.

This ticket does not have anything specifically user-facing, but it impacts T245224 (which has been tested & confirmed to function properly). I'm marking this work as Done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits