Page MenuHomePhabricator

Don't unmangle keys that don't match specified pattern
Closed, ResolvedPublicBUG REPORT

Description

Currently we're not checking if a key matches a pattern before we try to unmangle it.

For example, we have the following MANGLER pattern,

MANGLER:
  class: StringMatcher
  prefix: datadump-
  patterns:
    - action-*
    - apihelp-*

While importing, this should add datadump- prefix to any messages that begin with action- or apihelp-, and similarly when exporting it should only un-mangle those keys, and remove the datadump- prefix, but during export, it un-mangles all keys that start with datadump-.

Event Timeline

abi_ created this task.Apr 8 2020, 1:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2020, 1:06 PM
abi_ triaged this task as Medium priority.Apr 8 2020, 1:09 PM

Marking this with Medium priority since this causes trouble while importing messages since they are now renamed.

A patch has been submitted and merged - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/586346

abi_ closed this task as Resolved.Apr 9 2020, 4:51 AM

This was deployed and has fixed the issues we were having with DataDump and MatomoAnalytics. Commits,