Page MenuHomePhabricator

Collect First Input Delay with Prometheus
Closed, ResolvedPublic

Description

Currently only a crude statsd metric is collected. Prometheus would allow us to break it down into various criteria. This would be an easy first metric collected by the navtiming daemon to have on Prometheus.

Event Timeline

Gilles triaged this task as Medium priority.Apr 9 2020, 2:16 PM
Gilles moved this task from Inbox to Doing (old) on the Performance-Team board.

Change 587775 had a related patch set uploaded (by Gilles; owner: Gilles):
[performance/navtiming@master] Expose First Input Delay to Prometheus

https://gerrit.wikimedia.org/r/587775

Change 587775 merged by jenkins-bot:
[performance/navtiming@master] Expose First Input Delay to Prometheus

https://gerrit.wikimedia.org/r/587775

Assigning it to you Dave for deployment of the update. You can reassign the task to me once it's been deployed, thanks!

Change 591097 had a related patch set uploaded (by Gilles; owner: Gilles):
[performance/navtiming@master] Extend test coverage for FID and tweaks buckets

https://gerrit.wikimedia.org/r/591097

Gilles added a subscriber: dpifke.

Actually needs some tweaks first, see latest patch.

Change 591097 merged by jenkins-bot:
[performance/navtiming@master] Extend test coverage for FID and tweaks buckets

https://gerrit.wikimedia.org/r/591097

@dpifke when you deploy this, make sure to mention the task number in the SAL message. This way we can easily track on this task that the code change was deployed to production.

Mentioned in SAL (#wikimedia-operations) [2020-05-04T18:19:55Z] <dpifke@deploy1001> Started deploy [performance/navtiming@239d359]: Deploy navtiming with new/updated Prometheus metrics - T249822, T238086

Mentioned in SAL (#wikimedia-operations) [2020-05-04T18:20:00Z] <dpifke@deploy1001> Finished deploy [performance/navtiming@239d359]: Deploy navtiming with new/updated Prometheus metrics - T249822, T238086 (duration: 00m 05s)

Lo and behold: https://grafana.wikimedia.org/d/9zeb91jWk/first-input-delay now fully backed by Prometheus, with a parametric heatmap