Fix failing tests that rely on Hooks.php
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• nnikkhoui
	Apr 13 2020, 5:36 PM

Description

There are many tests that rely on parts of Hooks.php that will no longer exist, to pass.
One example is PrefixSearchTest:: testSearch that relies on access to the private field Hooks::$handlers (which no longer exists). to pass. We will need to fix all these tests to adhere to the new HookContainer.php.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Hide deprecated warnings for Hooks::clear()	mediawiki/core	master	+7 -0
	Fix failing tests relying on private Hooks.php properties	mediawiki/core	master	+0 -25

Customize query in gerrit

Event Timeline

• nnikkhoui created this task.Apr 13 2020, 5:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2020, 5:36 PM

• nnikkhoui added a project: Platform Team Workboards (Green).Apr 13 2020, 5:40 PM

• nnikkhoui moved this task from Backlog to Doing on the Platform Team Workboards (Green) board.

Sorry, didn't mean to remove that

Change 588473 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/core@master] Fix failing tests relying on private Hooks.php properties

https://gerrit.wikimedia.org/r/588473

gerritbot added a project: Patch-For-Review.Apr 13 2020, 7:54 PM

Change 588473 merged by jenkins-bot:
[mediawiki/core@master] Fix failing tests relying on private Hooks.php properties

https://gerrit.wikimedia.org/r/588473

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 14 2020, 4:00 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 14 2020, 4:10 AM

Change 588763 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/core@master] Hide deprecated warnings for Hooks::clear()

https://gerrit.wikimedia.org/r/588763

gerritbot added a project: Patch-For-Review.Apr 14 2020, 5:58 PM

Change 588763 merged by jenkins-bot:
[mediawiki/core@master] Hide deprecated warnings for Hooks::clear()

https://gerrit.wikimedia.org/r/588763

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 15 2020, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2020, 3:10 AM

• nnikkhoui moved this task from Doing to Done on the Platform Team Workboards (Green) board.Apr 15 2020, 5:37 PM

• nnikkhoui closed this task as Resolved.Apr 20 2020, 8:12 PM