Page MenuHomePhabricator

Fix failing tests that rely on Hooks.php
Closed, ResolvedPublic

Description

There are many tests that rely on parts of Hooks.php that will no longer exist, to pass.
One example is PrefixSearchTest:: testSearch that relies on access to the private field Hooks::$handlers (which no longer exists). to pass. We will need to fix all these tests to adhere to the new HookContainer.php.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2020, 5:36 PM

Change 588473 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/core@master] Fix failing tests relying on private Hooks.php properties

https://gerrit.wikimedia.org/r/588473

Change 588473 merged by jenkins-bot:
[mediawiki/core@master] Fix failing tests relying on private Hooks.php properties

https://gerrit.wikimedia.org/r/588473

Change 588763 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/core@master] Hide deprecated warnings for Hooks::clear()

https://gerrit.wikimedia.org/r/588763

Change 588763 merged by jenkins-bot:
[mediawiki/core@master] Hide deprecated warnings for Hooks::clear()

https://gerrit.wikimedia.org/r/588763

nnikkhoui closed this task as Resolved.Apr 20 2020, 8:12 PM