Page MenuHomePhabricator
Create Task
Maniphest T250268

mobile-html: add title description button should not show if there's no associated wikidata entity
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Open an article without an associated wikidata entity in mobile-html. For example, https://en.wikipedia.org/api/rest_v1/page/mobile-html/Bill_Boytchuk
  2. Observe the title description area

Actual Results:
Option to add a title description exists

Expected Results:
Option to add a title description does not exist

Details

SubjectRepoBranchLines +/-
Ensure "Add a title description" doesn't show when there's no associated Wikidata entitymediawiki/services/mobileappsmaster+25 -21
Customize query in gerrit

Related Objects

Event Timeline

JoeWalsh created this task.Apr 15 2020, 12:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2020, 12:10 PM
JoeWalsh triaged this task as High priority.Apr 15 2020, 12:11 PM
gerritbot added a comment.Apr 15 2020, 12:19 PM

Change 588998 had a related patch set uploaded (by Joewalsh; owner: Joewalsh):
[mediawiki/services/mobileapps@master] Ensure "Add a title description" doesn't show when there's no associated Wikidata entity

https://gerrit.wikimedia.org/r/588998

gerritbot added a project: Patch-For-Review.Apr 15 2020, 12:19 PM
JoeWalsh claimed this task.Apr 15 2020, 12:27 PM
JoeWalsh moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
JoeWalsh mentioned this in T250269: Unable to add or edit title descriptions.
• bearND subscribed.Apr 15 2020, 7:35 PM

Open an article without an associated wikidata entity

It would be good to add some example pages for this.

gerritbot added a comment.Apr 15 2020, 7:56 PM

Change 588998 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Ensure "Add a title description" doesn't show when there's no associated Wikidata entity

https://gerrit.wikimedia.org/r/588998

JoeWalsh updated the task description. (Show Details)Apr 15 2020, 7:56 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 15 2020, 8:10 PM
• bearND moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Apr 20 2020, 8:45 PM
• bearND closed this task as Resolved.Apr 28 2020, 5:24 PM
• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits