Page MenuHomePhabricator

DocBookExport extension: Call to undefined method ParserOptions::setEditSection()
Open, Needs TriagePublic

Description

Using DocBookExport (https://extdist.wmflabs.org/dist/extensions/DocBookExport-REL1_34-7a8aba8.tar.gz) with MediaWiki 1.34
throws
/var/www/mediawiki/extensions/DocBookExport/SpecialGetDocbook.php: Call to undefined method ParserOptions::setEditSection()
when trying to generate the book export.

Backtrace:
#0 /var/www/mediawiki/includes/specialpage/SpecialPage.php(575): SpecialGetDocbook->execute()
#1 /var/www/mediawiki/includes/specialpage/SpecialPageFactory.php(611): SpecialPage->run()
#2 /var/www/mediawiki/includes/MediaWiki.php(296): MediaWiki\Special\SpecialPageFactory->executePath()
#3 /var/www/mediawiki/includes/MediaWiki.php(900): MediaWiki->performRequest()
#4 /var/www/mediawiki/includes/MediaWiki.php(527): MediaWiki->main()
#5 /var/www/mediawiki/index.php(44): MediaWiki->run()
#6 {main}

I saw the ParserOptions::setEditSection() was removed and some other extensions fixed that were having the same problem
T235602 but the SpecialGetDocbook is still using deleted method ParserOptions::setEditSection()

line 195 :: SpecialGetDocbook.php

		$popts = new ParserOptions( $this->getUser() );
		$popts->enableLimitReport( false );
		$popts->setIsPreview( false );
		$popts->setIsSectionPreview( false );
--------->      $popts->setEditSection( false );
		$popts->setTidy( true );

Event Timeline

Hello, I have the same issue with Mediawiki 1.35

Change 1006110 had a related patch set uploaded (by GladwinJ; author: GladwinJ):

[mediawiki/extensions/DocBookExport@master] Remove ParserOptions::setEditSection

https://gerrit.wikimedia.org/r/1006110

Change 1006110 abandoned by GladwinJ:

[mediawiki/extensions/DocBookExport@master] Remove ParserOptions::setEditSection

Reason:

Pushed to the wrong branch, creating an alternate patch

https://gerrit.wikimedia.org/r/1006110

Change 1006867 had a related patch set uploaded (by GladwinJ; author: GladwinJ):

[mediawiki/extensions/DocBookExport@REL1_34] Remove ParserOptions::setEditSection

https://gerrit.wikimedia.org/r/1006867