We will review the patch

I don't remember when this was added, but I think you're supposed to set the toolbar's position in CSS as well, like this in Timeless: https://github.com/wikimedia/mediawiki-skins-Timeless/blob/master/resources/extensions/VisualEditor.core.less#L10 (which, curiously, doesn't set VisualEditorSkinToolbarScrollOffset…).

@Chrishel Have you had the time to try setting the position in CSS?

I tried using that css setting, and it seems like it could work but I'm having issues with the order of evaluation of style properties. It looks like that when visual editor is loaded, it sets the top to 0 via an embedded style tag which gets evaluated after my skin's scss file and thus VE's default value always overwrites what I try to set. If I use chrome's developer tools and disable the top property from the style tag so that my skin's value for top becomes active, it works. I'm not sure the most efficient way to be able to overwrite VE's value for this property if this is going to be considered the ideal solution for this problem moving forward.

Also, it looks like Chameleon at one point was trying to accomplish a similar css fix, but commented it out for some reason (https://github.com/ProfessionalWiki/chameleon/blob/master/resources/styles/_extensionfixes.scss#L23). Regardless, it seems like the toolbar doesn't position properly out of the box for Chameleon, so it seems like this issue remains unfixed for them?

You all obviously have a much better sense of the big picture, but it seems to be that since a VisualEditorSkinToolbarScrollOffset configuration directive exists which appears to be designed to solve this problem, the better solution might be to just fix that directive to function as intended rather than skins having to use their own css fixes which conceptually overlap with this directive? The downside to this approach seems to be that it's a bit inelegant to have to define a style property (i.e. the navbar height) in the PHP code of the skin rather than being able to handle everything in scss.

@Chrishel The recommended way is to put that rule in a separate CSS files, then put it in 'ResourceModuleSkinStyles' fo the module you want to override, like this: https://github.com/wikimedia/mediawiki-skins-Timeless/blob/master/skin.json#L100

If this is inconvenient (I guess it might be with SCSS?), then I'd just use !important ;), or increase the selector specificity.

The Editing team hasn't heard anything back regarding this task so we are moving it to the freezer.