Page MenuHomePhabricator

Mismatch between Jade requirements and some wikitools
Open, LowestPublic

Description

Issue: we don't actually make assessment on "goodfaith", but JADE validation requires it.
Issue: endorsementcomment is effectively required rather than optional

json5

        {
        "action": "jadeproposeorendorse",
        "title": `Jade:Diff/${revId}`,
        "facet": "editquality",
        // TODO(xinbenlv): we don't actually make assessment on "goodfaith", but validation requires it.
        "labeldata": `{"damaging":${isDamaging}, "goodfaith":true}`,
        "endorsementorigin": `WikiLoop Battelfield`,
        "notes": "Notes not available",
        "formatversion": "2",
        // TODO(xinbenlv): endorsementcomment is effectively required rather than optional
        "endorsementcomment": "SeemsRequired",
        "format":"json",
        "token": `+\\`, // TODO(xinbenlv): update with real CSRF token when JADE launch to production
      }

Event Timeline

Halfak renamed this task from WikiLoop post endorsement request to JADE to Mismatch between Jade requirements and some wikitools.May 18 2020, 5:05 PM
Halfak removed a project: ORES.
Halfak triaged this task as Medium priority.
Halfak moved this task from Unorganized to Epic on the Machine-Learning-Team board.
Aklapper lowered the priority of this task from Medium to Lowest.Sun, May 23, 10:54 PM