Page MenuHomePhabricator
Create Task
Maniphest T252509

thumbor: set Cache-Control ensuring cacheability on 404 responses
Closed, ResolvedPublic
Actions

Description

Thumbor currently sets Cache-Control: no-cache on all error responses. It should instead set Cache-Control: public, max-age=600 on 404 errors.

Details

SubjectRepoBranchLines +/-
ATS: cache thumbnail 404s despite of CCoperations/puppetproduction+20 -1
Upgrade to 2.7operations/debs/python-thumbor-wikimediamaster+111 -29
Allow caching 404 errorsoperations/software/thumbor-pluginsmaster+6 -2
Allow caching 404 errorsoperations/debs/python-thumbor-wikimediamaster+6 -2
Customize query in gerrit

Related Objects

Event Timeline

• ema created this task.May 12 2020, 8:25 AM
Restricted Application added a project: SRE. · View Herald TranscriptMay 12 2020, 8:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• ema renamed this task from thumbor: set Cache-Control on 404 responses that ensures cacheability to thumbor: set Cache-Control ensuring cacheability on 404 responses.May 12 2020, 8:25 AM
• ema triaged this task as High priority.
gerritbot added a comment.May 12 2020, 8:29 AM

Change 595875 had a related patch set uploaded (by Ema; owner: Ema):
[operations/debs/python-thumbor-wikimedia@master] Allow caching 404 errors

https://gerrit.wikimedia.org/r/595875

gerritbot added a project: Patch-For-Review.May 12 2020, 8:29 AM
gerritbot added a comment.May 12 2020, 8:51 AM

Change 595875 abandoned by Ema:
Allow caching 404 errors

Reason:
Wrong place!

https://gerrit.wikimedia.org/r/595875

gerritbot added a comment.May 12 2020, 8:55 AM

Change 595880 had a related patch set uploaded (by Ema; owner: Ema):
[operations/software/thumbor-plugins@master] Allow caching 404 errors

https://gerrit.wikimedia.org/r/595880

gerritbot added a comment.May 12 2020, 9:19 AM

Change 595880 merged by Gilles:
[operations/software/thumbor-plugins@master] Allow caching 404 errors

https://gerrit.wikimedia.org/r/595880

gerritbot added a comment.May 12 2020, 9:23 AM

Change 595886 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] ATS: cache thumbnail 404s despite of CC

https://gerrit.wikimedia.org/r/595886

gerritbot added a comment.May 12 2020, 9:41 AM

Change 595891 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 2.7

https://gerrit.wikimedia.org/r/595891

• ema merged a task: T252425: Thumbor/Swift proxy should serve Cache-Control headers for 404s.May 12 2020, 10:22 AM
• ema added a subscriber: • Gilles.
gerritbot added a comment.May 12 2020, 1:17 PM

Change 595891 merged by Ema:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 2.7

https://gerrit.wikimedia.org/r/595891

Stashbot mentioned this in T236240: Ghostscript outputs errors to stdout despite -q, preventing Thumbor from generating some thumbnails properly.May 12 2020, 1:50 PM
Stashbot mentioned this in T219569: libvips thumbnail generation fails for TIFF files with invalid ICC profiles.

Mentioned in SAL (#wikimedia-operations) [2020-05-12T13:50:55Z] <ema> thumbor2001: upgrade python-thumbor-wikimedia to 2.7-1+deb10u1 T252509 T219569 T236240

Stashbot added a comment.May 12 2020, 1:54 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-12T13:54:21Z] <ema> thumbor2001: pool thumbor 2.7-1+deb10u1 for prod traffic T252509 T219569 T236240

Stashbot added a comment.May 12 2020, 2:00 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-12T14:00:48Z] <ema> thumbor2001: depool due to minor bug in 2.7-1+deb10u1 T252509 T219569 T236240

Stashbot added a comment.May 12 2020, 2:33 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-12T14:33:11Z] <ema> thumbor2001: upgrade python-thumbor-wikimedia to 2.8-1+deb10u1 T252509 T219569 T236240

Stashbot added a comment.May 12 2020, 2:40 PM

Mentioned in SAL (#wikimedia-operations) [2020-05-12T14:39:57Z] <ema> rolling thumbor upgrade to 2.8-1+deb10u1 T252509 T219569 T236240

gerritbot added a comment.May 12 2020, 2:52 PM

Change 595886 abandoned by Ema:
ATS: cache thumbnail 404s despite of CC

Reason:
This isn't needed, thumbor 2.8 (now in prod) does the right thing.

https://gerrit.wikimedia.org/r/595886

• Gilles closed this task as Resolved.EditedMay 12 2020, 2:53 PM
• Gilles claimed this task.

Ratio of 404s to 200s on Thumbor is now back to its pre-2020-04-30 level.

Maintenance_bot removed a project: Patch-For-Review.May 12 2020, 3:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL