legaltitlechars in mw.config and from API don't match (\xFF is not the same as \uFFFF)
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	SD0001
	May 21 2020, 2:18 PM

Description

The value mw.config.get('wgLegalTitleChars') in the JS interface and the legaltitlechars value from ApiQuerySiteInfo are not same or equivalent.

Running the following in the javascript console:

new mw.Api().get( {
	"meta": "siteinfo",
	"siprop": "general"
} ).then( function( data ) {
	console.log( data.query.general.legaltitlechars + '\t\tAPI version' );
	console.log( mw.config.get('wgLegalTitleChars') + '\tmw.config version' );
} );

gives:

%!"$&'()*,\-.\/0-9:;=?@A-Z\\^_`a-z~\x80-\xFF+		API version
%!"$&'()*,\-./0-9:;=?@A-Z\\\^_`a-z~+\u0080-\uFFFF	mw.config version

\xFF isn't the same as \uFFFF, apart from the apparent differences in the number of \ characters used for escaping.

Shouldn't these be the equivalent?

The mw.config version seems to be the correct one. There are some titles such as File:Michał Cieślak Sejm 2016.JPG containing \u0142 and \u015b, which shouldn't be allowed according to the API version.

Related Objects

Mentioned Here: rMWdc9c9ee7fc6d: Title: Add byte class to unicode class conversion for js

Event Timeline

SD0001 created this task.May 21 2020, 2:18 PM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptMay 21 2020, 2:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

SD0001 updated the task description. (Show Details)May 21 2020, 2:21 PM

Aklapper renamed this task from legaltitlechars in mw.config and from API don't match to legaltitlechars in mw.config and from API don't match (\xFF is not the same as \uFFFF).May 22 2020, 9:25 AM

SD0001 updated the task description. (Show Details)May 25 2020, 1:24 PM

OK, we'll take a look.

• eprodromou moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.May 26 2020, 8:40 PM

• AMooney edited projects, added Platform Engineering (Icebox); removed Platform Team Workboards (Clinic Duty Team), MediaWiki-Action-API, JavaScript.Aug 12 2020, 5:19 PM

@AMooney: Assuming that "Set projects" was accidentally used instead of "Add projects", hence restoring some previous project tags.

The mw.config version seems to be the correct one.

The API version is the canonical one as it just echoes the original source of the regex.

The value mw.config.get('wgLegalTitleChars') in the JS interface and the legaltitlechars value from ApiQuerySiteInfo are not same or equivalent.

It's intentional that they are different. The result from mw.config object (meant for JS) is a modified version of the canonical value so it returns unicode code value representaion of the UTF-8 bytes (as used in PHP). cf. dc9c9ee7fc6d

legaltitlechars in mw.config and from API don't match (\xFF is not the same as \uFFFF)Closed, InvalidPublicActions

Description

Related Objects

Event Timeline

legaltitlechars in mw.config and from API don't match (\xFF is not the same as \uFFFF)
Closed, InvalidPublic
Actions