Page MenuHomePhabricator

Ensure WikibaseDataModel has hash stability tests for all hash methods
Closed, ResolvedPublic

Description

When fixing T243590 it was highlighted that some DataModel hashes are calculated from PHP serialize and unserialzie methods.
Generally speaking, these hashes are meant to be stable and should not unexpectedly change.
The PR fixing the tests added a stability check for the hash of the ReferenceList object, and while looking around the code a few other stability checks where also spotted.
To be sure we should audit the code and add tests for stability for all gethash methods

Event Timeline

Addshore created this task.May 26 2020, 2:36 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptMay 26 2020, 2:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore renamed this task from Ensure WikibaseDataModel has hash stability trsts for all hash methods to Ensure WikibaseDataModel has hash stability tests for all hash methods.May 26 2020, 2:37 PM
toan claimed this task.May 26 2020, 2:44 PM
Addshore closed this task as Resolved.May 27 2020, 9:36 AM

I'll makw followup tickets for a release and using the new version everywhere