Page MenuHomePhabricator

CodeReview codecomments API module using unnecessarily confusing parameter name
Closed, ResolvedPublic

Description

Sort of related to bug 23366, as far as I can see, the CodeReview codecomments module calls the status field "revision." This is brain-dead.

From http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CodeReview/api/ApiCodeComments.php?revision=65186&view=markup
83 if ( isset( $this->props['revision'] ) )
84 $item['status'] = $row->cr_status;

The parameter should be called "status" for the status, surely. And the revision parameter should store the revision number. I guess this would be a breaking change, but I think it's a necessary one.


Version: unspecified
Severity: normal

Details

Reference
bz23367

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:04 PM
bzimport set Reference to bz23367.
bzimport added a subscriber: Unknown Object (MLST).

Fixed in r65756. Not a breaking change as I didn't remove ccprop=revision , just deprecated it in favor of the equivalent ccprop=status .