Page MenuHomePhabricator

Restore banners to skins (Vector)
Closed, ResolvedPublic

Description

With I58c2ff5edaacc2d5e45492c121cf0f87d08b623f Vector dropped support for the pre-body-html BaseTemplate key. This caused the banners to disappear from Vector.
Example: https://en.wikivoyage.beta.wmflabs.org/wiki/Bannerda

While the above change could be reverted, given the low activity and the time until the next SWAT window I'd rather use the time to clean up the convoluted code somewhat to make it more resilient to the other changes we have planned in Vector.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 602142 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/WikidataPageBanner@master] Simplify wikidatabanner injection and restore banners to Vector

https://gerrit.wikimedia.org/r/602142

Jdlrobson renamed this task from Restore banners to Vector to Restore banners to skins (Vector).Jun 3 2020, 7:34 PM

Change 602376 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Drop MinervaEnableSiteNotice

https://gerrit.wikimedia.org/r/602376

Change 602376 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Drop MinervaEnableSiteNotice

https://gerrit.wikimedia.org/r/602376

Change 602523 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Revert "Drop MinervaEnableSiteNotice"

https://gerrit.wikimedia.org/r/602523

Change 602524 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Enable site notices on wikivoyage projects

https://gerrit.wikimedia.org/r/602524

Change 602142 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@master] Simplify wikidatabanner injection and restore banners to Vector

https://gerrit.wikimedia.org/r/602142

Change 602523 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Revert "Drop MinervaEnableSiteNotice"

https://gerrit.wikimedia.org/r/602523

Change 602524 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable site notices on wikivoyage projects

https://gerrit.wikimedia.org/r/602524

Mentioned in SAL (#wikimedia-operations) [2020-06-04T23:29:33Z] <catrope@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Enable Minerva site notices on Wikivoyage wiis (T254391) (duration: 00m 58s)