Page MenuHomePhabricator
Create Task
Maniphest T254495

Use eslint-config-wikimedia 0.17.x in all repositories with Selenium tests
Open, Needs TriagePublic
Actions

Description

TODO

Notes

eslint-config-wikimedia 0.17.x simplified eslint configuration for Selenium tests.

Update eslint-config-wikimedia version to 0.17.x in all repositories with Selenium tests. Also, replace contents of tests/selenium/.eslintrc.json file.

Example old file from mediawiki/core repository.

{
	"root": true,
	"extends": [
		"wikimedia",
		"wikimedia/node",
		"wikimedia/language/es2017",
		"wikimedia/jquery"
	],
	"env": {
		"mocha": true
	},
	"globals": {
		"browser": "readonly",
		"mw": "readonly"
	},
	"rules": {
		"no-jquery/no-global-selector": "off"
	}
}

Example new file:

{
	"root": true,
	"extends": [
		"wikimedia/selenium"
	]
}
RepositoryPatch
mediawiki/core596468
mediawiki/extensions/AbuseFilter602836
mediawiki/extensions/AdvancedSearch604842
mediawiki/extensions/CirrusSearch605358
mediawiki/extensions/Cite603952
mediawiki/extensions/ContentTranslation603959
mediawiki/extensions/Echo605331
mediawiki/extensions/ElectronPdfService605156
mediawiki/extensions/EntitySchema607653
mediawiki/extensions/FileImporter606381
mediawiki/extensions/GrowthExperiments607099
mediawiki/extensions/Math605936
mediawiki/extensions/MobileFrontend601860
mediawiki/extensions/Newsletter607006
mediawiki/extensions/ORES607121
mediawiki/extensions/Popups607129
mediawiki/extensions/ProofreadPage607003
mediawiki/extensions/RelatedArticles607351
mediawiki/extensions/RevisionSlider605925
mediawiki/extensions/TemplateWizard607005
mediawiki/extensions/TwoColConflict605182
mediawiki/extensions/Wikibase614765 693439
mediawiki/extensions/WikibaseLexeme606274
mediawiki/extensions/WikibaseMediaInfo607359
mediawiki/skins/MinervaNeue601864
phab-deployment616183
wikibase/termboxT265656

Details

SubjectRepoBranchLines +/-
WIP eslint: Update eslint-config-wikimediamediawiki/extensions/Wikibasemaster+1 K -105
eslint: Update to eslint-config-wikimedia 0.16.2wikimedia/portals/deploymaster+1 K -740
eslint: Update to eslint-config-wikimedia 0.16.0 and eslint 7.5.0phabricator/deploymentwmf/stable+940 -558
eslint: update selenium .estlintrc.jsonmediawiki/extensions/Wikibasemaster+31 -39
eslint: Update to eslint-config-wikimedia 0.16.2mediawiki/extensions/EntitySchemamaster+869 -414
eslint: Update to eslint-config-wikimedia 0.16.1mediawiki/extensions/CirrusSearchmaster+516 -205
eslint: Update to eslint-config-wikimedia 0.16.0mediawiki/extensions/AdvancedSearchmaster+773 -151
zuul: Add Jared G. Blumer to trusted usersintegration/configmaster+1 -0
eslint: Update to eslint-config-wikimedia 0.16.0mediawiki/extensions/AbuseFiltermaster+269 -289
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
zeljkofilipin updated the task description. (Show Details)Jun 9 2020, 10:48 AM
gerritbot added a comment.Jun 9 2020, 6:54 PM

Change 602836 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] eslint: Update to eslint-config-wikimedia 0.16.0

https://gerrit.wikimedia.org/r/602836

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 9 2020, 7:00 PM
zeljkofilipin updated the task description. (Show Details)Jun 10 2020, 11:27 AM
jaredblumer updated the task description. (Show Details)Jun 11 2020, 7:16 PM
zeljkofilipin updated the task description. (Show Details)Jun 12 2020, 10:47 AM
zeljkofilipin updated the task description. (Show Details)Jun 12 2020, 10:50 AM
zeljkofilipin updated the task description. (Show Details)Jun 12 2020, 2:12 PM
zeljkofilipin updated the task description. (Show Details)
gerritbot added a comment.Jun 12 2020, 2:19 PM

Change 604842 had a related patch set uploaded (by Jared Blumer; owner: Jared Blumer):
[mediawiki/extensions/AdvancedSearch@master] eslint: Update to eslint-config-wikimedia 0.16.0

https://gerrit.wikimedia.org/r/604842

gerritbot added a comment.Jun 12 2020, 2:41 PM

Change 605247 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] zuul: Add Jared G. Blumer to trusted users

https://gerrit.wikimedia.org/r/605247

gerritbot added a comment.Jun 12 2020, 3:08 PM

Change 604842 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] eslint: Update to eslint-config-wikimedia 0.16.0

https://gerrit.wikimedia.org/r/604842

gerritbot added a comment.Jun 12 2020, 3:11 PM

Change 605247 merged by jenkins-bot:
[integration/config@master] zuul: Add Jared G. Blumer to trusted users

https://gerrit.wikimedia.org/r/605247

jaredblumer updated the task description. (Show Details)Jun 12 2020, 4:41 PM
gerritbot added a comment.Jun 13 2020, 1:53 PM

Change 605358 had a related patch set uploaded (by Jared Blumer; owner: Jared Blumer):
[mediawiki/extensions/CirrusSearch@master] eslint: Update to eslint-config-wikimedia 0.16.0

https://gerrit.wikimedia.org/r/605358

jaredblumer updated the task description. (Show Details)Jun 13 2020, 1:55 PM
zeljkofilipin updated the task description. (Show Details)Jun 15 2020, 4:50 PM
zeljkofilipin updated the task description. (Show Details)Jun 16 2020, 11:05 AM
zeljkofilipin updated the task description. (Show Details)Jun 16 2020, 4:00 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 17 2020, 10:38 AM
zeljkofilipin moved this task from Learn/Teach 💡 to Project ♟ on the User-zeljkofilipin board.Jun 17 2020, 4:16 PM
zeljkofilipin updated the task description. (Show Details)Jun 18 2020, 10:00 AM
zeljkofilipin updated the task description. (Show Details)Jun 18 2020, 10:03 AM
zeljkofilipin renamed this task from Use eslint-config-wikimedia 0.16.0 in all repositories with Selenium tests to Use eslint-config-wikimedia 0.16.1 in all repositories with Selenium tests.Jun 19 2020, 9:58 AM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 19 2020, 10:01 AM
zeljkofilipin added a parent task: T210726: Selenium framework cleanup.
zeljkofilipin mentioned this in T210726: Selenium framework cleanup.
zeljkofilipin added subscribers: Vidhi-Mody, Soham.Jun 19 2020, 10:03 AM
zeljkofilipin mentioned this in T252878: Don't use "wikimedia/jquery" in selenium .eslintrc.Jun 23 2020, 3:06 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 23 2020, 3:09 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 23 2020, 3:12 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 23 2020, 3:14 PM
gerritbot added a comment.Jun 23 2020, 6:19 PM

Change 605358 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] eslint: Update to eslint-config-wikimedia 0.16.1

https://gerrit.wikimedia.org/r/605358

zeljkofilipin updated the task description. (Show Details)Jun 23 2020, 6:23 PM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.39; 2020-06-30); removed MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 23 2020, 7:00 PM
zeljkofilipin updated the task description. (Show Details)Jun 24 2020, 12:39 PM
zeljkofilipin updated the task description. (Show Details)Jun 24 2020, 12:42 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin renamed this task from Use eslint-config-wikimedia 0.16.1 in all repositories with Selenium tests to Use eslint-config-wikimedia 0.16.x in all repositories with Selenium tests.Jun 24 2020, 12:51 PM
zeljkofilipin updated the task description. (Show Details)
gerritbot added a comment.Jun 25 2020, 3:06 AM

Change 607653 had a related patch set uploaded (by Jared Blumer; owner: Jared Blumer):
[mediawiki/extensions/EntitySchema@master] eslint: Update to eslint-config-wikimedia 0.16.2

https://gerrit.wikimedia.org/r/607653

jaredblumer updated the task description. (Show Details)Jun 25 2020, 3:10 AM
zeljkofilipin updated the task description. (Show Details)Jun 26 2020, 9:38 AM
zeljkofilipin updated the task description. (Show Details)Jun 29 2020, 2:47 PM
gerritbot added a comment.Jul 1 2020, 4:07 PM

Change 607653 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] eslint: Update to eslint-config-wikimedia 0.16.2

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/ /607653

zeljkofilipin updated the task description. (Show Details)Jul 1 2020, 4:55 PM
zeljkofilipin updated the task description. (Show Details)Jul 4 2020, 9:52 AM
zeljkofilipin updated the task description. (Show Details)Jul 9 2020, 9:55 AM
gerritbot added a comment.Jul 20 2020, 3:41 PM

Change 614765 had a related patch set uploaded (by Jared Blumer; owner: Jared Blumer):
[mediawiki/extensions/Wikibase@master] eslint: update selenium .estlintrc.json

https://gerrit.wikimedia.org/r/614765

jaredblumer updated the task description. (Show Details)Jul 20 2020, 3:42 PM
gerritbot added a comment.Jul 22 2020, 1:58 AM

Change 614765 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] eslint: update selenium .estlintrc.json

https://gerrit.wikimedia.org/r/614765

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 22 2020, 2:00 AM
zeljkofilipin updated the task description. (Show Details)Jul 22 2020, 11:42 AM
jaredblumer updated the task description. (Show Details)Jul 24 2020, 10:30 PM
jaredblumer updated the task description. (Show Details)Jul 24 2020, 11:32 PM
gerritbot added a comment.Jul 24 2020, 11:35 PM

Change 616183 had a related patch set uploaded (by Jared Blumer; owner: Jared Blumer):
[phabricator/deployment@wmf/stable] eslint: Update to eslint-config-wikimedia 0.16.0 and eslint 7.5.0

https://gerrit.wikimedia.org/r/616183

gerritbot added a comment.Jul 28 2020, 5:18 AM

Change 616183 merged by 20after4:
[phabricator/deployment@wmf/stable] eslint: Update to eslint-config-wikimedia 0.16.0 and eslint 7.5.0

https://gerrit.wikimedia.org/r/616183

jaredblumer mentioned this in rPHDEP26a008c190b0: eslint: Update to eslint-config-wikimedia 0.16.0 and eslint 7.5.0.Jul 28 2020, 5:42 AM
zeljkofilipin updated the task description. (Show Details)Jul 28 2020, 5:02 PM
gerritbot added a comment.Aug 8 2020, 1:31 AM

Change 619079 had a related patch set uploaded (by Jared Blumer; owner: Jared Blumer):
[wikimedia/portals/deploy@master] eslint: Update to eslint-config-wikimedia 0.16.2

https://gerrit.wikimedia.org/r/619079

jaredblumer updated the task description. (Show Details)Aug 8 2020, 1:32 AM
gerritbot added a comment.Sep 18 2020, 12:25 PM

Change 619079 merged by jenkins-bot:
[wikimedia/portals/deploy@master] eslint: Update to eslint-config-wikimedia 0.16.2

https://gerrit.wikimedia.org/r/619079

zeljkofilipin updated the task description. (Show Details)Sep 18 2020, 1:44 PM
zeljkofilipin added a comment.Sep 23 2020, 5:04 PM

@jaredblumer do you need help with the remaining two repositories?

jaredblumer added a comment.Sep 23 2020, 9:05 PM
In T254495#6488380, @zeljkofilipin wrote:

@jaredblumer do you need help with the remaining two repositories?

@zeljkofilipin I will be working on this this weekend and will follow the steps we discussed. Sorry for the delay on these last two!

zeljkofilipin added a comment.Sep 24 2020, 8:16 AM

@jaredblumer take your time, I just wanted to make check if you need help. 😁

zeljkofilipin added a comment.Sep 24 2020, 8:19 AM

@jaredblumer I've just noticed that you didn't have the volunteer badge. Well, now you have! 🏅 (I'm not sure if Phabricator sends e-mail notification for that.)

https://phabricator.wikimedia.org/people/badges/25156/

jaredblumer added a comment.EditedSep 27 2020, 10:04 PM

@zeljkofilipin wikidata/query/gui does not use eslint-config-wikimedia as a dependency and does not have a .eslintrc.json file. It does, however, have one test (included below). Should this be repo be removed from the task or should I add the dependency and eslintrc.json file?

/* jshint strict: false */
/* globals require, describe, it, browser, $ */
var assert = require( 'assert' );

describe( 'embed.html', function() {
	it( 'loads results for query', function() {
		var query =
			'SELECT ?item ?itemLabel ?other WHERE { '
			+ ' VALUES (?item ?itemLabel ?other) { '
			+ '     (wd:Q42 "Douglas Adams"@en "1952-03-11T00:00:00Z"^^xsd:dateTime) '
			+ '     (wd:Q80 "Tim Berners-Lee"@de <http://commons.wikimedia.org/wiki/Special:FilePath/Sir%20Tim%20Berners-Lee%20%28cropped%29.jpg>)'
			+ ' } }';

		return browser.url( browser.options.baseUrl + '/embed.html#' + encodeURI( query ) )
			.then( function() {
				return $( '#query-result' );
			} ).then( function( element ) {
				return element.isExisting();
			} ).then( function( isExisting ) {
				assert( isExisting );
			} );
	} );
} );
zeljkofilipin renamed this task from Use eslint-config-wikimedia 0.16.x in all repositories with Selenium tests to Use eslint-config-wikimedia 0.17.x in all repositories with Selenium tests.Sep 28 2020, 3:26 PM
zeljkofilipin updated the task description. (Show Details)
jaredblumer updated the task description. (Show Details)Sep 28 2020, 3:42 PM
zeljkofilipin mentioned this in T265656: Use eslint-config-wikimedia 0.17.x in wikibase/termbox.Oct 16 2020, 10:34 AM
Richa1496 mentioned this in T266752: Outreachy Project Proposal: Selenium Framework Cleanup .Oct 29 2020, 11:34 AM
zeljkofilipin removed jaredblumer as the assignee of this task.Nov 9 2020, 4:11 PM
zeljkofilipin moved this task from Project ♟ to Backlog 🪒 on the User-zeljkofilipin board.
zeljkofilipin added a subscriber: jaredblumer.
zeljkofilipin mentioned this in T272142: Mentor coworkers, volunteers and interns.Jan 15 2021, 12:31 PM
zeljkofilipin claimed this task.May 18 2021, 10:03 AM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin updated the task description. (Show Details)May 20 2021, 5:56 PM
zeljkofilipin updated the task description. (Show Details)May 21 2021, 1:42 PM
gerritbot added a comment.May 21 2021, 2:55 PM

Change 693439 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/extensions/Wikibase@master] WIP eslint: Update eslint-config-wikimedia

https://gerrit.wikimedia.org/r/693439

zeljkofilipin updated the task description. (Show Details)May 21 2021, 2:56 PM
gerritbot added a comment.May 21 2021, 3:07 PM

Change 693439 abandoned by Zfilipin:

[mediawiki/extensions/Wikibase@master] WIP eslint: Update eslint-config-wikimedia

Reason:

https://gerrit.wikimedia.org/r/693439

zeljkofilipin removed zeljkofilipin as the assignee of this task.May 21 2021, 3:08 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin moved this task from Deep work 🌊 to Backlog 🪒 on the User-zeljkofilipin board.
hashar subscribed.Jun 24 2021, 8:18 AM

Note that wikimedia/portals/deploy selenium tests got entirely broken after https://gerrit.wikimedia.org/r/c/wikimedia/portals/deploy/+/619079 cause it added some extra it when the test helper already returned it. Fixed by https://gerrit.wikimedia.org/r/c/wikimedia/portals/deploy/+/701087

zeljkofilipin raised the priority of this task from Medium to Needs Triage.Sep 17 2021, 9:30 AM
zeljkofilipin edited projects, added Browser-Tests; removed Quality-and-Test-Engineering-Team.Oct 7 2021, 5:54 PM
hashar unsubscribed.Apr 20 2022, 10:19 AM
zeljkofilipin updated the task description. (Show Details)Mar 17 2023, 2:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL