Page MenuHomePhabricator

HookRunner as service
Closed, DeclinedPublic5 Estimated Story Points

Description

Add new service to ServiceContainer

MediaWikiServices::getInstance()->getHookRunner()

for
\MediaWiki\HookContainer\ProtectedHookAccessorTrait::getHookRunner

	protected function getHookRunner() {
		return new HookRunner( $this->getHookContainer() );
	}

to simple test mocked hook methods

Event Timeline

Helga_sf triaged this task as High priority.
Helga_sf raised the priority of this task from High to Needs Triage.Jul 1 2020, 3:36 PM
Helga_sf set the point value for this task to 3.
Helga_sf changed the point value for this task from 3 to 5.

This not going to work as extension should create own HookRunner. It is recommended to create the HookRunner where needed as the class is a simple and cheap to create. That is also the used pattern all over in core.

There is no need to create global service here. Would suggest to decline this task.

Aklapper added a project: MediaWiki-General.

Declining per last comment