Page MenuHomePhabricator

Peter.ovchyn (Peter.ovchyn)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 13 2020, 1:12 PM (6 w, 2 d)
Availability
Available
LDAP User
Peter.ovchyn
MediaWiki User
Unknown

Recent Activity

Today

Peter.ovchyn added a comment to T246076: Wrong definition of MW_ENTRY_POINT when integration tests run..

There is no runBare defined in MediaWiki in the mentioned class. If this is part of a work in progress, be sure to add a link to that as well :)

Thu, Feb 27, 11:15 AM · MediaWiki-General, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T246209: Create wireframe for extension from Backlog to Waiting for Review on the Core Platform Team Workboards (Contractor Workboard) board.
Thu, Feb 27, 9:58 AM · MediaWiki-extensions-MediaModeration, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard)

Yesterday

Peter.ovchyn created T246209: Create wireframe for extension.
Wed, Feb 26, 11:10 AM · MediaWiki-extensions-MediaModeration, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T246206: PhotoDNA integration from Backlog to Doing on the Core Platform Team Workboards (Contractor Workboard) board.
Wed, Feb 26, 10:53 AM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn updated the task description for T246206: PhotoDNA integration.
Wed, Feb 26, 10:47 AM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn created T246206: PhotoDNA integration.
Wed, Feb 26, 10:46 AM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn updated the task description for T246076: Wrong definition of MW_ENTRY_POINT when integration tests run..
Wed, Feb 26, 10:39 AM · MediaWiki-General, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn updated the task description for T245595: MediaModeration extension MVP.
Wed, Feb 26, 10:13 AM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn updated the task description for T245595: MediaModeration extension MVP.
Wed, Feb 26, 10:12 AM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn updated the task description for T246078: Add SQLite infra to Jenkins CI.
Wed, Feb 26, 8:04 AM · Release-Engineering-Team (CI & Testing services), SQLite, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T243310: Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler. from Ready to Next Sprint on the Core Platform Team Workboards (Contractor Workboard) board.
Wed, Feb 26, 8:03 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn moved T243310: Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler. from Doing to Ready on the Core Platform Team Workboards (Contractor Workboard) board.
Wed, Feb 26, 8:03 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn moved T245995: Sqlite Integration tests fail on macOS php 7.4 from Doing to Waiting for Review on the Core Platform Team Workboards (Contractor Workboard) board.
Wed, Feb 26, 8:02 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), MediaWiki-General, SQLite, Core Platform Team Workboards (Contractor Workboard)

Tue, Feb 25

Peter.ovchyn updated the task description for T245595: MediaModeration extension MVP.
Tue, Feb 25, 2:04 PM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn added a comment to T246006: Name Hash Checking Extension.

I prefer AutoMediaModeration. Almost 'AutomaticMediaModeration' but shorter.

Tue, Feb 25, 12:47 PM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn added a comment to T245995: Sqlite Integration tests fail on macOS php 7.4.

Fixed 4 out of 5 tests related to data representation.

FAILURES!
Tests: 42, Assertions: 407, Failures: 1, Risky: 1.
Script phpunit --colors=always --testsuite=core:integration,extensions:integration,skins:integration handling the phpunit:integration event returned with error code 1
Tue, Feb 25, 9:43 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), MediaWiki-General, SQLite, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn renamed T246078: Add SQLite infra to Jenkins CI from Add SQLite infra Jenkins CI to Add SQLite infra to Jenkins CI.
Tue, Feb 25, 9:36 AM · Release-Engineering-Team (CI & Testing services), SQLite, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn created T246078: Add SQLite infra to Jenkins CI.
Tue, Feb 25, 9:36 AM · Release-Engineering-Team (CI & Testing services), SQLite, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn created T246077: SQlite has wrong DB structure after upgrading to 1.35.
Tue, Feb 25, 9:32 AM · MW-1.35-release, MediaWiki-Installer, MediaWiki-User-management, SQLite, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn created T246076: Wrong definition of MW_ENTRY_POINT when integration tests run..
Tue, Feb 25, 9:19 AM · MediaWiki-General, Core Platform Team Workboards (Contractor Workboard)

Mon, Feb 24

Peter.ovchyn moved T245993: SqliteInstallerTest::testCheckDataDir fails on php7.4, OS: macOS Catalina from Waiting for Review to Closed on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 24, 5:10 PM · SQLite, MediaWiki-Installer, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T245995: Sqlite Integration tests fail on macOS php 7.4 from Backlog to Doing on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 24, 5:08 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), MediaWiki-General, SQLite, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn added a comment to T245964: Factor some static methods out of the ChangeTags class.

Encapsulating a global state into a class is always a good idea.
At the moment I'm not quite familiar with that area, so can't give you more valuable suggestion.

Mon, Feb 24, 3:53 PM · User-DannyS712, MediaWiki-Change-tagging
Peter.ovchyn updated the task description for T245995: Sqlite Integration tests fail on macOS php 7.4.
Mon, Feb 24, 1:49 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), MediaWiki-General, SQLite, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn updated the task description for T245995: Sqlite Integration tests fail on macOS php 7.4.
Mon, Feb 24, 1:48 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), MediaWiki-General, SQLite, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn created T245995: Sqlite Integration tests fail on macOS php 7.4.
Mon, Feb 24, 1:48 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), MediaWiki-General, SQLite, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T245993: SqliteInstallerTest::testCheckDataDir fails on php7.4, OS: macOS Catalina from Backlog to Waiting for Review on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 24, 12:08 PM · SQLite, MediaWiki-Installer, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn added a project to T245993: SqliteInstallerTest::testCheckDataDir fails on php7.4, OS: macOS Catalina: Core Platform Team Workboards (Contractor Workboard).
Mon, Feb 24, 12:07 PM · SQLite, MediaWiki-Installer, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn created T245993: SqliteInstallerTest::testCheckDataDir fails on php7.4, OS: macOS Catalina.
Mon, Feb 24, 12:02 PM · SQLite, MediaWiki-Installer, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn committed rEMME4b14ac109c9d: parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices (authored by Peter.ovchyn).
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices
Mon, Feb 24, 9:50 AM
Peter.ovchyn moved T243306: Introduce shorthand to LanguageConverter for al SpecialPage hierarchy from Waiting for Review to Closed on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 24, 9:10 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn moved T244709: Add more doc annotations to LanguageConverter related classes from Waiting for Review to Closed on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 24, 9:10 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T243754: Add tests for SearchNearMatcher:: getNearMatch that cover case for language with variants from Waiting for Review to Closed on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 24, 9:10 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n

Sun, Feb 23

Peter.ovchyn committed rEFFD5a9d3e340e24: parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices (authored by Peter.ovchyn).
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices
Sun, Feb 23, 9:53 AM

Fri, Feb 21

Peter.ovchyn added a comment to T245595: MediaModeration extension MVP.

I would propose to NOT make a standalone service for this, but instead make a MediaWiki extension and rely heavily on the JobQueue.

Fri, Feb 21, 9:58 AM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn claimed T245595: MediaModeration extension MVP.
Fri, Feb 21, 9:35 AM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T245595: MediaModeration extension MVP from Backlog to Doing on the Core Platform Team Workboards (Contractor Workboard) board.
Fri, Feb 21, 9:35 AM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)

Thu, Feb 20

Peter.ovchyn moved T245075: Improve file attribution for “Called deprecation function” logs from Backlog to Next Sprint on the Core Platform Team Workboards (Contractor Workboard) board.
Thu, Feb 20, 10:40 AM · Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-Debug-Logger
Peter.ovchyn committed rENWT98eb11203100: parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices (authored by Peter.ovchyn).
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices
Thu, Feb 20, 9:26 AM

Wed, Feb 19

Peter.ovchyn created T245595: MediaModeration extension MVP.
Wed, Feb 19, 10:45 AM · MediaWiki-extensions-MediaModeration, Core Platform Team Workboards (Contractor Workboard)

Tue, Feb 18

D3r1ck01 awarded T244055: Replace Parser's creation from "Parser::__constructor" to "ParserFactory::create" across all the code a Like token.
Tue, Feb 18, 6:51 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MediaWiki-extensions-General, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn added a comment to T244055: Replace Parser's creation from "Parser::__constructor" to "ParserFactory::create" across all the code.

While reading this, I was thinking about a private constructor. Not sure if that makes sense, but it would be an alternative to a code style rule.

Tue, Feb 18, 2:12 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MediaWiki-extensions-General, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn added a comment to T244055: Replace Parser's creation from "Parser::__constructor" to "ParserFactory::create" across all the code.

Didn’t get you. What do you mean by shorter/longer form?

short = new Parser()
long = MediaWikiServices::getInstance()->getParserFactory()->create()

Tue, Feb 18, 11:56 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MediaWiki-extensions-General, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn claimed T244055: Replace Parser's creation from "Parser::__constructor" to "ParserFactory::create" across all the code.
Tue, Feb 18, 11:48 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MediaWiki-extensions-General, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T243306: Introduce shorthand to LanguageConverter for al SpecialPage hierarchy from Doing to Waiting for Review on the Core Platform Team Workboards (Contractor Workboard) board.
Tue, Feb 18, 11:20 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n

Mon, Feb 17

Peter.ovchyn added a comment to T244055: Replace Parser's creation from "Parser::__constructor" to "ParserFactory::create" across all the code.

Is there a follow up change to the coding convention check. Otherwise people like me might reintroduce the shorter alternative in the future without being aware of the longer form.

Mon, Feb 17, 7:45 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MediaWiki-extensions-General, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard)

Thu, Feb 13

Peter.ovchyn added a comment to T245075: Improve file attribution for “Called deprecation function” logs.

I agree with fixing the wrong caller. But I totally disagree with the fact that this layer isn't useful. It has a couple advantages:

  1. It encapsulates all logic inside so that you shouldn't write if ( !$languageConverter ) {
  2. Standardize the deprecation of outdated signatures. So that it can be used everywhere.
  3. It can easily be matched by automation tools so that we won't forget to remove the next versions.
  4. We use wfDeprecation for different purposes:
  5. signature changes
  6. public variables deprecation (decreasing the visibility or moving variable to new class etc..)
  7. Function deprecations

...

Thu, Feb 13, 10:57 AM · Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-Debug-Logger
Peter.ovchyn updated the task description for T245128: Remove deprecated code from SpecialPageFactory.
Thu, Feb 13, 9:59 AM · MediaWiki-Special-pages, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn created T245128: Remove deprecated code from SpecialPageFactory.
Thu, Feb 13, 9:58 AM · MediaWiki-Special-pages, Core Platform Team Workboards (Contractor Workboard)

Wed, Feb 12

Nikerabbit awarded T243913: Decrease public variables in Language class a Like token.
Wed, Feb 12, 3:39 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Internationalization, CPT Initiatives (Decoupling (CDP2)), I18n
Peter.ovchyn placed T243515: Refactor MediaWikiServices::forceGlobalInstance to return void instead of old instance. up for grabs.
Wed, Feb 12, 10:05 AM · Core Platform Team Workboards (Contractor Workboard), MediaWiki-Core-Testing, MediaWiki-ServiceContainer
Peter.ovchyn placed T243323: Inject LanguageConverter through constructor in SearchNearMatcher up for grabs.
Wed, Feb 12, 10:05 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243756: Add more tests class SkinTemplate up for grabs.
Wed, Feb 12, 10:04 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243910: Refactor ConverterRule not to use public variables from LanguageConverter and remove mutual dependency between them up for grabs.
Wed, Feb 12, 10:04 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243755: Add pure unit-tests for SearchMySQL, SearchSqlite etc... up for grabs.
Wed, Feb 12, 10:04 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243751: Add tests for DefaultPreferencesFactory::profilePreferences up for grabs.
Wed, Feb 12, 10:04 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243750: Add test for ParserOptionsTest:optionsHash that covers case when language has variants up for grabs.
Wed, Feb 12, 10:04 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243326: Rename ILanguageInterface::convert function to eliminate ambiguity up for grabs.
Wed, Feb 12, 10:04 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243747: Add pure unit tests for class LinkHolderArray up for grabs.
Wed, Feb 12, 10:04 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243744: Add tests for ContentHandler::getPageViewLanguage up for grabs.
Wed, Feb 12, 10:04 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243743: Add tests MessageCache::updateMessageOverride up for grabs.
Wed, Feb 12, 10:03 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243325: Avoid LanguageConverter from usage of Language by introducing specialised interface up for grabs.
Wed, Feb 12, 10:03 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n

Tue, Feb 11

Peter.ovchyn moved T244055: Replace Parser's creation from "Parser::__constructor" to "ParserFactory::create" across all the code from Backlog to Doing on the Core Platform Team Workboards (Contractor Workboard) board.
Tue, Feb 11, 10:22 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MediaWiki-extensions-General, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn updated the task description for T244055: Replace Parser's creation from "Parser::__constructor" to "ParserFactory::create" across all the code.
Tue, Feb 11, 9:40 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MediaWiki-extensions-General, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T243310: Once we have ContentHandlerFactory, we can think about injecting the LanguageConverterFactory into ContentHandler. from Next Sprint to Doing on the Core Platform Team Workboards (Contractor Workboard) board.
Tue, Feb 11, 9:34 AM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n

Mon, Feb 10

Peter.ovchyn closed T244128: Add respective deprecations from class Language to RELEASE-NOTES-1.35 as Resolved.
Mon, Feb 10, 8:12 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn closed T243461: Decrease visibility of public variables in LanguageConverter class as Resolved.
Mon, Feb 10, 7:47 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn removed a project from T243754: Add tests for SearchNearMatcher:: getNearMatch that cover case for language with variants: Core Platform Team.
Mon, Feb 10, 7:11 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn moved T243754: Add tests for SearchNearMatcher:: getNearMatch that cover case for language with variants from Doing to Waiting for Review on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 10, 7:09 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn added a comment to T243754: Add tests for SearchNearMatcher:: getNearMatch that cover case for language with variants.

96% of the lines are covered.

Mon, Feb 10, 7:09 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn moved T243461: Decrease visibility of public variables in LanguageConverter class from Waiting for Review to Closed on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 10, 2:51 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn moved T244128: Add respective deprecations from class Language to RELEASE-NOTES-1.35 from Waiting for Review to Closed on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 10, 2:47 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn renamed T244709: Add more doc annotations to LanguageConverter related classes from LanguageConverter small follow-ups after final review to Add more doc annotations to LanguageConverter related classes.
Mon, Feb 10, 2:26 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T244709: Add more doc annotations to LanguageConverter related classes from Doing to Waiting for Review on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 10, 2:25 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T243754: Add tests for SearchNearMatcher:: getNearMatch that cover case for language with variants from Next Sprint to Doing on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 10, 10:34 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn moved T244709: Add more doc annotations to LanguageConverter related classes from Backlog to Doing on the Core Platform Team Workboards (Contractor Workboard) board.
Mon, Feb 10, 10:33 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn claimed T244709: Add more doc annotations to LanguageConverter related classes.
Mon, Feb 10, 10:33 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn renamed T244709: Add more doc annotations to LanguageConverter related classes from LanguageConverter related follow-up after final review. to LanguageConverter small follow-ups after final review.
Mon, Feb 10, 10:26 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn created T244709: Add more doc annotations to LanguageConverter related classes.
Mon, Feb 10, 10:25 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, Core Platform Team Workboards (Contractor Workboard)

Sat, Feb 8

Peter.ovchyn moved T221949: Remove uses of Title::moveTo from Doing to Closed on the Core Platform Team Workboards (Contractor Workboard) board.
Sat, Feb 8, 3:35 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team, Core Platform Team Workboards (Contractor Workboard), MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-Maintenance, MediaWiki-extensions-LiquidThreads, MediaWiki-extensions-UserMerge, Wikidata, Patch-For-Review, User-DannyS712, CPT Initiatives (Decoupling (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Technical-Debt (Deprecation process)
Peter.ovchyn moved T243953: Remove Title::moveTo from Waiting for Review to Closed on the Core Platform Team Workboards (Contractor Workboard) board.
Sat, Feb 8, 3:34 PM · Core Platform Team, Core Platform Team Workboards (Contractor Workboard), MediaWiki-General

Fri, Feb 7

Peter.ovchyn moved T223099: Factor code for handling for options (preferences) out of User class from Ready to Backlog on the Core Platform Team Workboards (Contractor Workboard) board.
Fri, Feb 7, 9:08 AM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team Workboards (Contractor Workboard), Wikimedia-Hackathon-2019, Patch-For-Review, MediaWiki-User-management, MediaWiki-User-preferences

Wed, Feb 5

Peter.ovchyn moved T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207 from Doing to Waiting for Review on the Core Platform Team Workboards (Contractor Workboard) board.
Wed, Feb 5, 3:10 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-General, Wikimedia-production-error
Peter.ovchyn moved T243323: Inject LanguageConverter through constructor in SearchNearMatcher from Doing to Backlog on the Core Platform Team Workboards (Contractor Workboard) board.
Wed, Feb 5, 3:09 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn added a comment to T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.

Generally speaking, the removal of StubUserLang may have side effects (because RequestContext::getLanguage would be called earlier). Alternative hotfixes that I can think of are removing the typehint from Title::getLanguageConverter, or adding StubObject::unstub( $wgLang ); in Title::getPageLanguage, before returning $wgLang (this can probably be considered a medium-term solution).

Wed, Feb 5, 12:57 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-General, Wikimedia-production-error
Peter.ovchyn claimed T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.
Wed, Feb 5, 12:24 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-General, Wikimedia-production-error
Peter.ovchyn moved T244128: Add respective deprecations from class Language to RELEASE-NOTES-1.35 from Doing to Waiting for Review on the Core Platform Team Workboards (Contractor Workboard) board.
Wed, Feb 5, 12:21 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn reassigned T226834: In LanguageConverter, replace usages of Title with usages of LinkTarget from D3r1ck01 to Art-Baltai.
Wed, Feb 5, 11:52 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Core Platform Team, Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter
Peter.ovchyn added a comment to T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.

I've found a cause submitted a patch/hotfix. Don't think this is the best option, but reverting isn't promising to be painless also as a lot of changes are based on the top of that patch.

Wed, Feb 5, 9:21 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-General, Wikimedia-production-error

Tue, Feb 4

Peter.ovchyn moved T243306: Introduce shorthand to LanguageConverter for al SpecialPage hierarchy from Next Sprint to Doing on the Core Platform Team Workboards (Contractor Workboard) board.
Tue, Feb 4, 10:22 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn moved T244128: Add respective deprecations from class Language to RELEASE-NOTES-1.35 from Next Sprint to Doing on the Core Platform Team Workboards (Contractor Workboard) board.
Tue, Feb 4, 9:56 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn moved T244128: Add respective deprecations from class Language to RELEASE-NOTES-1.35 from Backlog to Next Sprint on the Core Platform Team Workboards (Contractor Workboard) board.
Tue, Feb 4, 9:56 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Contractor Workboard)
Peter.ovchyn updated the task description for T243910: Refactor ConverterRule not to use public variables from LanguageConverter and remove mutual dependency between them.
Tue, Feb 4, 9:41 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn updated the task description for T243910: Refactor ConverterRule not to use public variables from LanguageConverter and remove mutual dependency between them.
Tue, Feb 4, 9:18 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn added a comment to T243323: Inject LanguageConverter through constructor in SearchNearMatcher.

It's turned out that this task is not that easy:

  1. SearchNearMatcher is created from SearchEngine::getNearMatcher.
public function getNearMatcher( Config $config ) {
	return new SearchNearMatcher( $config,
		MediaWikiServices::getInstance()->getContentLanguage() );
}
  1. SearchEngine is abstract class which might have different implementations. But it's created by SearchEngineFactory
public function create( $type = null ) {
	$configuredClass = $this->config->getSearchType();
	$alternativesClasses = $this->config->getSearchTypes();
Tue, Feb 4, 8:48 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn updated the task description for T243323: Inject LanguageConverter through constructor in SearchNearMatcher.
Tue, Feb 4, 8:32 PM · Core Platform Team Workboards (Contractor Workboard), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243759: Add tests for class User, increase coverage to 50% up for grabs.
Tue, Feb 4, 3:16 PM · Core Platform Team, CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn placed T243758: Add tests for class Title, increase coverage to 75% up for grabs.
Tue, Feb 4, 3:16 PM · Core Platform Team, CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn removed a project from T243759: Add tests for class User, increase coverage to 50%: Core Platform Team Workboards (Contractor Workboard).
Tue, Feb 4, 3:16 PM · Core Platform Team, CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, I18n
Peter.ovchyn renamed T244128: Add respective deprecations from class Language to RELEASE-NOTES-1.35 from Add respective deprecations in RELEASE-NOTES-1.35 to Add respective deprecations from class Language to RELEASE-NOTES-1.35 .
Tue, Feb 4, 2:45 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Contractor Workboard)