Add pure unit-tests for SearchMySQL, SearchSqlite etc...
Open, Needs TriagePublic13 Estimated Story Points
Actions

Assigned To

None

Authored By

	Peter.ovchyn
	Jan 27 2020, 11:00 AM

Description

Motivation:

Looks like SearchMySQL, SearchSqlite, etc don't seem to have any unit tests.
https://doc.wikimedia.org/cover/mediawiki-core/includes/search/SearchMySQL.php.html

Expected result:

More tests should be added.
at least classes SearchMySQL, SearchSqlite should be covered 100%

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add pure unit-tests for SearchMySQL, SearchSqlite etc	mediawiki/core	master	+679 -127

Customize query in gerrit

Event Timeline

Peter.ovchyn created this task.Jan 27 2020, 11:00 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJan 27 2020, 11:00 AM

Peter.ovchyn removed a parent task: T226833: Introduce LanguageConverterFactory service.Jan 30 2020, 1:20 PM

daniel removed a project: Platform Engineering.Feb 5 2020, 7:28 PM

Peter.ovchyn removed Peter.ovchyn as the assignee of this task.Feb 12 2020, 10:04 AM

Helga_sf moved this task from Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 5:18 PM

Helga_sf set the point value for this task to 13.Apr 16 2020, 10:09 AM

Helga_sf moved this task from Estimated/Estimation to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.

Helga_sf assigned this task to Art-Baltai.Apr 16 2020, 10:16 AM

Art-Baltai moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Apr 17 2020, 11:34 AM

Change 592326 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] Add pure unit-tests for SearchMySQL, SearchSqlite etc

https://gerrit.wikimedia.org/r/592326

gerritbot added a project: Patch-For-Review.Apr 24 2020, 3:31 AM

Art-Baltai moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.May 4 2020, 4:40 PM

Helga_sf reassigned this task from Art-Baltai to Peter.ovchyn.Jun 23 2020, 5:07 PM

Helga_sf added a subscriber: Art-Baltai.

Helga_sf removed a subscriber: Art-Baltai.

Peter.ovchyn moved this task from In Progress/In Review to Backlog on the Platform Team Workboards (S&F Workboard) board.Oct 21 2020, 12:36 PM

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Aug 16 2022, 10:11 AM

roman-stolar claimed this task.Aug 26 2022, 11:03 AM

Winston_Sung moved this task from Backlog to Core on the MediaWiki-Language-converter board.Mar 18 2023, 4:04 AM

@roman-stolar: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on October 11th.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

	F31535306: Screenshot 2020-01-27 at 12.59.50.png
	Jan 27 2020, 11:00 AM

Add pure unit-tests for SearchMySQL, SearchSqlite etc...Open, Needs TriagePublic13 Estimated Story PointsActions