Page MenuHomePhabricator
Create Task
Maniphest T271596

Migrate relevant User method usages to GroupPermissionsLookup and hard-deprecate User methods.
Closed, ResolvedPublic
Actions

Description

All usages of

  • User::groupHasPermission,
  • User::getGroupsWithPermission and
  • User::getGroupPermissions

must be replaced with relevant methods in GroupPermissionsLookup and the User methods must be hard deprecated

Details

SubjectRepoBranchLines +/-
Replace static User::getGroupsWithPermission in favour of GroupPermissionsLookupmediawiki/extensions/CodeReviewmaster+5 -2
Replace static User::getGroupsWithPermission in favour of GroupPermissionsLookupmediawiki/extensions/CodeReviewmaster+5 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Jan 8 2021, 11:38 PM
• Pchelolo moved this task from Unsorted pile to Authority pile on the Platform Team Workboards (MW Expedition) board.Jan 11 2021, 5:52 PM
Peter.ovchyn updated the task description. (Show Details)Jan 12 2021, 5:00 PM
gerritbot added a comment.Jan 14 2021, 4:11 PM

Change 656204 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/CodeReview@master] Replace static User::getGroupsWithPermission in favour of GroupPermissionsLookup

https://gerrit.wikimedia.org/r/656204

gerritbot added a project: Patch-For-Review.Jan 14 2021, 4:11 PM
• Pchelolo moved this task from Authority pile to Blocked on the Platform Team Workboards (MW Expedition) board.Jan 14 2021, 8:13 PM
gerritbot added a comment.Jan 18 2021, 2:59 PM

Change 656904 had a related patch set uploaded (by Vlad.shapik; owner: Peter.ovchyn):
[mediawiki/extensions/CodeReview@master] Replace static User::getGroupsWithPermission in favour of GroupPermissionsLookup

https://gerrit.wikimedia.org/r/656904

gerritbot added a comment.Jan 18 2021, 3:04 PM

Change 656904 abandoned by Vlad.shapik:
[mediawiki/extensions/CodeReview@master] Replace static User::getGroupsWithPermission in favour of GroupPermissionsLookup

Reason:

https://gerrit.wikimedia.org/r/656904

• Pchelolo triaged this task as Medium priority.Jan 19 2021, 6:26 PM
gerritbot added a comment.Jan 20 2021, 1:44 AM

Change 656204 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Replace static User::getGroupsWithPermission in favour of GroupPermissionsLookup

https://gerrit.wikimedia.org/r/656204

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 20 2021, 2:00 AM
• Pchelolo moved this task from Blocked to On the train on the Platform Team Workboards (MW Expedition) board.Jan 21 2021, 8:50 PM
• Pchelolo closed this task as Resolved.Feb 1 2021, 6:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits