Page MenuHomePhabricator

LiquidThreads Extension, Threads: Use WikiPage argument instead of Article argument
Open, LowPublic3 Estimated Story Points

Description

LiquidThreads, Threads methods use Article unnecessarily

Event Timeline

Helga_sf renamed this task from LiquidThreads Extension: Change calls to LiquidThreads Extension, Threads: Use WikiPage argument instead of Article argument .May 4 2020, 12:39 PM
Helga_sf updated the task description. (Show Details)
Aklapper renamed this task from LiquidThreads Extension, Threads: Use WikiPage argument instead of Article argument to LiquidThreads Extension, Threads: Use WikiPage argument instead of Article argument.May 4 2020, 12:50 PM

Too many similar(union) work with a low priority:

\ThreadPermalinkView::__construct
\ThreadProtectionFormView::__construct
\LqtView::__construct

Looks like possible but has too many works with minimal profit

This is part of hook contract:
\LqtDeletionController::onArticleConfirmDelete

Is already WikiPage
\LqtHooks::onPageContentSaveComplete

Other is created from title

Helga_sf set the point value for this task to 3.Oct 6 2020, 10:21 AM

I get feedback from Petr Pchelko. He said that the ticket was not really worthy of implementing.