Page MenuHomePhabricator

LiquidThreads Extension, Threads: Use WikiPage argument instead of Article argument
Open, LowPublic

Description

LiquidThreads, Threads methods use Article unnecessarily

Event Timeline

Helga_sf created this task.May 4 2020, 12:37 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMay 4 2020, 12:37 PM
Helga_sf renamed this task from LiquidThreads Extension: Change calls to LiquidThreads Extension, Threads: Use WikiPage argument instead of Article argument .May 4 2020, 12:39 PM
Helga_sf updated the task description. (Show Details)
Aklapper renamed this task from LiquidThreads Extension, Threads: Use WikiPage argument instead of Article argument to LiquidThreads Extension, Threads: Use WikiPage argument instead of Article argument.May 4 2020, 12:50 PM
Pchelolo triaged this task as Low priority.May 4 2020, 11:53 PM
Art-Baltai added a comment.EditedMay 5 2020, 12:05 AM

Too many similar(union) work with a low priority:

\ThreadPermalinkView::__construct
\ThreadProtectionFormView::__construct
\LqtView::__construct

Looks like possible but has too many works with minimal profit

This is part of hook contract:
\LqtDeletionController::onArticleConfirmDelete

Is already WikiPage
\LqtHooks::onPageContentSaveComplete

Other is created from title

Helga_sf removed a subscriber: Art-Baltai.
Peter.ovchyn removed Peter.ovchyn as the assignee of this task.Tue, Jul 7, 1:45 PM
Peter.ovchyn added a subscriber: Peter.ovchyn.