Page MenuHomePhabricator
Create Task
Maniphest T243756

Add more tests class SkinTemplate
Open, Needs TriagePublic
Actions

Description

Motivation:

SkinTemplateTest exists but hardly tests anything.
https://doc.wikimedia.org/cover/mediawiki-core/includes/skins/SkinTemplate.php.html

Screenshot 2020-01-27 at 13.05.11.png (62×1 px, 22 KB)

Expected result:

  • More tests should be added.
  • class SkinTemplate should be covered 100%

Details

SubjectRepoBranchLines +/-
SkinTemplate: increase test coverage.mediawiki/coremaster+737 -2
Customize query in gerrit

Event Timeline

Peter.ovchyn created this task.Jan 27 2020, 11:07 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJan 27 2020, 11:07 AM
Peter.ovchyn updated the task description. (Show Details)Jan 27 2020, 11:48 AM
Art-Baltai moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Jan 30 2020, 4:25 PM
Art-Baltai moved this task from Current sprint Backlog to Backlog on the Platform Team Workboards (S&F Workboard) board.
Peter.ovchyn removed a parent task: T226833: Introduce LanguageConverterFactory service.Jan 31 2020, 9:46 AM
daniel removed a project: Platform Engineering.Feb 5 2020, 7:28 PM
Peter.ovchyn removed Peter.ovchyn as the assignee of this task.Feb 12 2020, 10:04 AM
Helga_sf moved this task from Backlog to Estimated/Estimation on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 5:18 PM
gerritbot added a comment.Apr 3 2020, 2:05 AM

Change 585628 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] SkinTemplate test coverage

https://gerrit.wikimedia.org/r/585628

gerritbot added a project: Patch-For-Review.Apr 3 2020, 2:05 AM
• Pchelolo edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards (S&F Workboard).Apr 6 2020, 10:33 PM
• Pchelolo edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).
• Pchelolo edited projects, added Platform Team Workboards (S&F Workboard); removed Platform Team Workboards (External Code Reviews).
Art-Baltai moved this task from Estimated/Estimation to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Apr 9 2020, 1:43 PM
Art-Baltai claimed this task.Apr 13 2020, 11:56 AM
Art-Baltai moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.
Helga_sf reassigned this task from Art-Baltai to Peter.ovchyn.Jun 23 2020, 5:06 PM
Helga_sf added a subscriber: Art-Baltai.
Helga_sf removed a subscriber: Art-Baltai.
Peter.ovchyn removed Peter.ovchyn as the assignee of this task.Oct 21 2020, 12:31 PM
Peter.ovchyn moved this task from In Progress/In Review to Backlog on the Platform Team Workboards (S&F Workboard) board.
Winston_Sung moved this task from Backlog to Extensions/Skins on the MediaWiki-Language-converter board.Mar 18 2023, 4:04 AM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 2 2023, 1:05 AM
Winston_Sung moved this task from Extensions/Skins to Core on the MediaWiki-Language-converter board.Apr 8 2023, 6:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits