undesirable space after external link url in printout
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Worden.lee
	May 11 2010, 10:28 PM

Description

remove extra space from a.external.text rule in commonPrint.css

When printing an external link, the stylesheet appends the link's URL with surrounding spaces. The final space is inappropriate when the link is followed by punctuation, and unnecessary otherwise.

For instance, "[http://mediawiki.org MediaWiki], a popular free software package" prints as "MediaWiki (http://mediawiki.org) , a popular free software package".

Patch included to get rid of the extra space.

Version: 1.21.x
Severity: minor

attachment commonPrint.patch ignored as obsolete

Details

Reference: bz23472

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:10 PM

• bzimport added projects: MediaWiki-User-Interface, good first task.

• bzimport set Reference to bz23472.

• bzimport added a subscriber: Unknown Object (MLST).

Worden.lee created this task.May 11 2010, 10:28 PM

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

sumanah wrote:

Thanks for the patch, Lee! Sorry for the long wait. I am adding the "need-review" keyword so developers know that this patch hasn't been reviewed yet.

sumanah wrote:

Lee, I'm sorry that, because of the delay, your patch no longer applies to MediaWiki's current codebase. Is the bug still happening? If so, would you be interested in updating your patch? If you do, and attach the "need-review" and "patch" keywords, we'll make sure to review it a lot faster. Again, I'm sorry.

sumanah wrote:

Comment on attachment 7360
remove extra space from a.external.text rule in commonPrint.css

Patch no longer applies to MediaWiki trunk in Subversion.
Tested by Rusty in http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html

Seems to still apply:

$:andre\> grep -r "attr(href)" .
./common/commonPrint.css: content: " (" attr(href) ") ";

https://gerrit.wikimedia.org/r/#/c/55518/ seems to address this bug.

undesirable space after external link url in printoutClosed, ResolvedPublicActions

Description

Details

Event Timeline

undesirable space after external link url in printout
Closed, ResolvedPublic
Actions