Page MenuHomePhabricator
Create Task
Maniphest T255534

Extract mtail puppet.git tests to a standalone CI container
Closed, DeclinedPublic
Actions

Description

The docker-registry.wikimedia.org/releng/operations-puppet image includes mtail. There are tests in puppet.git requiring it.

I would like to extract that to a standalone container outside of operations-puppet like we did for logstash-filter-verifier T251869 . That requires some test entry point like we did for https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/594460/

Related Objects

Event Timeline

hashar created this task.Jun 16 2020, 7:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2020, 7:04 AM
hashar mentioned this in T251466: Upgrade mtail to 3.0.0-rc35.Jun 16 2020, 7:34 AM
hashar triaged this task as Medium priority.Jun 16 2020, 10:46 AM

Maybe including mtail is less of an issue than logstash-filter-verifier given it is lightweight and the test suite is blazing fast.

thcipriani edited projects, added Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)); removed Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)).Jul 8 2020, 5:34 PM
fgiunchedi added a comment.Jul 20 2020, 12:58 PM

Indeed, mtail is also tiny compared to the logstash stack. The downside I see in this case is that we'd lose the mtail tests by default when running utils/run_ci_locally.sh. I'm for punting on this for now, what do you think ?

fgiunchedi moved this task from Inbox to Radar on the observability board.Jul 20 2020, 12:59 PM
thcipriani edited projects, added Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).Oct 21 2020, 1:07 AM
thcipriani removed a project: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)).Apr 20 2021, 12:21 AM
thcipriani added a project: Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)).Apr 20 2021, 12:34 AM
thcipriani edited projects, added Release-Engineering-Team (Doing); removed Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)).Apr 20 2021, 4:25 AM
hashar closed this task as Declined.Jun 4 2021, 12:39 PM

Declining since mtail is rather small per Filippo

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits