Improve the error message presented when attempting to undelete a page for which the topmost revision is hidden
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	May 19 2010, 10:36 AM

Description

Author: FT2.wiki

Description:
To reproduce:

1/ Create a page with one revision
2/ Delete the page using normal delete
3/ Apply RevDelete to hide the content of the deleted revision
4/ Try to undelete the page using normal delete.

The same can happen on pages with many revisions if selective undelete is used, when RevDelete happens to be applied to the latest revision to be selectively undeleted. (Eg in cases of vandalism or page move fixing)

Example, try undeleting the following:

http://en.wikipedia.org/w/index.php?title=Special:Undelete&target=User%3AFT2%2Ftest5

Error is correct but inelegant and inaccurate, suggesting something has not been caught or some text parameter is missing.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=28632

Details

Reference: bz23594

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Invalid	None	T40638 [DO NOT USE] Interface messages needing rewording or documentation and other issues with existing messages [superseded by #Voice_&_Tone]
Resolved	None	T25594 Improve the error message presented when attempting to undelete a page for which the topmost revision is hidden
		· · ·

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:07 PM

• bzimport added a project: MediaWiki-User-Interface.

• bzimport set Reference to bz23594.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.May 19 2010, 10:36 AM

I can't reproduce. When doing your steps (on trunk) i get:

Undelete failed; someone else may have undeleted the page first.

Undeletion will not be performed if it will result in the top page or file revision being partially deleted. In such cases, you must uncheck or unhide the newest deleted revision.

Can you confirm if the error is still present?

FT2.wiki wrote:

Looks like this edge case has been caught since 2010 by some kind of extra test for the top page or file being deleted. It now acts as I'd expect, error if the text is hidden, allows it if the edit summary is hidden.

The error message has a slight bug, the presence of <p></p>:

"Undelete failed; someone else may have undeleted the page first."
"<p></p>"

The error message should also by default link to the delete log for the page - it's telling the user there is probably an issue related to delete/undelete. At present the error doesn't give any useful links the user can click.

EN.WP.ST47 wrote:

This appears to be fixed except that the message isn't quite as useful as it could be, but there is no obvious bug or uncaught error. The error message could use a link to the appropriate delete log entry. However the message has been updated since FT2's comment, there is no longer an empty p tag. Marking the bug appropriately, as it is not a revision deletion error.

mhershberger wrote:

Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

sumanah wrote:

Still an issue?

https://test.wikipedia.org/wiki/Special:Undelete/Bug23594 :

Undelete failed:

Undeletion will not be performed if it will result in the top page or file revision being partially deleted.