Page MenuHomePhabricator
Create Task
Maniphest T256950

Delete sample or skipped Selenium tests
Closed, ResolvedPublic
Actions

Description

Of all repositories having selenium tests a few contain only sample/ skipped tests. (See: T253869: Estimate size of tests/selenium folder)

Selenium tests need to be deleted from the following repositories:

  1. mediawiki/extensions/ContentTranslation ( contains only sample tests ) -> @Richa1496 634981
  2. mediawiki/extensions/ORES ( contains only skipped tests ) -> @Harriet @Akanksha_Bhattachan 634994

Steps to be followed:

  • Delete files from the tests/selenium folder
  • Remove all WebdriverIO packages from package.json
  • Remove all related selenium scripts from package.json

Have a look at the following patch for reference:

Details

SubjectRepoBranchLines +/-
Selenium: Delete all testsmediawiki/extensions/ORESmaster+918 -4 K
Selenium: delete all testsmediawiki/extensions/ContentTranslationmaster+1 -3 K
Customize query in gerrit

Related Objects

Event Timeline

zeljkofilipin created this task.Jul 2 2020, 9:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2020, 9:29 AM
zeljkofilipin triaged this task as Medium priority.Jul 2 2020, 9:29 AM
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.
zeljkofilipin updated the task description. (Show Details)Jul 2 2020, 9:39 AM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added subscribers: Vidhi-Mody, Soham.
zeljkofilipin mentioned this in T210726: Selenium framework cleanup.Oct 15 2020, 4:33 PM
zeljkofilipin assigned this task to Vidhi-Mody.Oct 19 2020, 9:46 AM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin moved this task from Backlog to In Progress on the User-Vidhi-Mody board.
Vidhi-Mody updated the task description. (Show Details)Oct 19 2020, 1:08 PM
Vidhi-Mody removed Vidhi-Mody as the assignee of this task.Oct 19 2020, 1:40 PM
Vidhi-Mody mentioned this in T265011: Outreachy: Selenium Microtasks.Oct 19 2020, 1:42 PM
zeljkofilipin moved this task from Backlog 🪒 to Learn/Teach 💡 on the User-zeljkofilipin board.Oct 19 2020, 1:55 PM
Richa1496 updated the task description. (Show Details)Oct 19 2020, 2:03 PM
Richa1496 subscribed.
santana subscribed.Oct 19 2020, 2:13 PM
gerritbot added a comment.Oct 19 2020, 2:57 PM

Change 634994 had a related patch set uploaded (by Harriet Ayugi; owner: Harriet Ayugi):
[mediawiki/extensions/ORES@master] Tests: Delete skipped Selenium tests

https://gerrit.wikimedia.org/r/634994

gerritbot added a project: Patch-For-Review.Oct 19 2020, 2:57 PM
gerritbot added a comment.Oct 19 2020, 5:41 PM

Change 634981 had a related patch set uploaded (by Richa Sharma; owner: Richa Sharma):
[mediawiki/extensions/ContentTranslation@master] Deleted sample tests

https://gerrit.wikimedia.org/r/634981

Js636f subscribed.Oct 20 2020, 7:16 AM
gerritbot added a comment.Oct 20 2020, 7:33 AM

Change 634981 had a related patch set uploaded (by Richa Sharma; owner: Richa Sharma):
[mediawiki/extensions/ContentTranslation@master] Deleted sample tests

https://gerrit.wikimedia.org/r/634981

gerritbot added a comment.Oct 20 2020, 7:40 AM

Change 634981 had a related patch set uploaded (by Richa Sharma; owner: Richa Sharma):
[mediawiki/extensions/ContentTranslation@master] Deleted sample tests

https://gerrit.wikimedia.org/r/634981

Js636f added a comment.Oct 20 2020, 8:18 AM

Hello!

My patch from the previous task still was not merged because of CI failure. May I work on this task or that patch should be merged first? If I may then I have a question about this task. Which repository should I clean? Is it one of the repos from the description, or it should be a repository from the list?

Thank you!

zeljkofilipin added a comment.Oct 20 2020, 10:15 AM
In T256950#6563146, @Js636f wrote:

My patch from the previous task still was not merged because of CI failure. May I work on this task or that patch should be merged first?

You don't have to wait for your open patches to be merged before you start a new one. It is normal to have several open patches at any point.

If I may then I have a question about this task. Which repository should I clean? Is it one of the repos from the description, or it should be a repository from the list?

This task only has two repositories, and two applicants are already working. I would suggest that you pick another task.

Js636f added a comment.Oct 20 2020, 10:22 AM

@zeljkofilipin Thank you! OK! Where can I find a new task? Should I wait for it to appear in T265011 description? Or you may give me a task?

gerritbot added a comment.Oct 20 2020, 11:04 AM

Change 634981 had a related patch set uploaded (by Richa Sharma; owner: Richa Sharma):
[mediawiki/extensions/ContentTranslation@master] Deleted sample tests

https://gerrit.wikimedia.org/r/634981

zeljkofilipin added a comment.Oct 20 2020, 1:27 PM
In T256950#6563523, @Js636f wrote:

@zeljkofilipin Thank you! OK! Where can I find a new task? Should I wait for it to appear in T265011 description? Or you may give me a task?

New tasks will be added to T265011 as they are ready.

gerritbot added a comment.Oct 20 2020, 2:03 PM

Change 634981 had a related patch set uploaded (by Richa Sharma; owner: Richa Sharma):
[mediawiki/extensions/ContentTranslation@master] Selenium: deleted all sample tests.

https://gerrit.wikimedia.org/r/634981

gerritbot added a comment.Oct 20 2020, 3:03 PM

Change 634981 had a related patch set uploaded (by Richa Sharma; owner: Richa Sharma):
[mediawiki/extensions/ContentTranslation@master] Selenium: deleted all sample tests The only test is a sample test that isn't really testing anything.

https://gerrit.wikimedia.org/r/634981

Akanksha_Bhattachan updated the task description. (Show Details)Oct 21 2020, 8:14 AM
Akanksha_Bhattachan added subscribers: Akanksha_Bhattachan, Harriet.
gerritbot added a comment.Oct 26 2020, 1:22 PM

Change 634981 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Selenium: delete all tests

https://gerrit.wikimedia.org/r/634981

gerritbot added a comment.Oct 28 2020, 6:20 PM

Change 634994 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Selenium: Delete all tests

https://gerrit.wikimedia.org/r/634994

zeljkofilipin closed this task as Resolved.Oct 28 2020, 7:45 PM
zeljkofilipin claimed this task.

A big thank you to everybody that worked on this task!

Akanksha_Bhattachan added a comment.EditedOct 29 2020, 6:48 AM
In T256950#6586073, @zeljkofilipin wrote:

A big thank you to everybody that worked on this task!

@zeljkofilipin : Its Pleasure working on the team :) . Thank you & team too for this opportunity.

Harriet added a comment.Oct 29 2020, 9:20 AM
In T256950#6586073, @zeljkofilipin wrote:

A big thank you to everybody that worked on this task!

It has been great collaborating on this task. Thank you

zeljkofilipin removed zeljkofilipin as the assignee of this task.Oct 29 2020, 11:46 AM
Akanksha_Bhattachan mentioned this in T266923: Outreachy 21 - Proposal (Evaluate Microsoft Playwright as replacement for our browser automation).Oct 31 2020, 4:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits