Page MenuHomePhabricator

Undefined index: name in includes/filerepo/ForeignAPIRepo.php on line 157
Closed, ResolvedPublic

Description

Author: KameraadPjotr

Description:
patch

In ForeignAPIRepo.php the index 'name' of $img on line 157 is undeclared, which returns a E_NOTICE. Patch included below.


Version: 1.17.x
Severity: trivial

Attached:

Details

Reference
bz23703

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:01 PM
bzimport set Reference to bz23703.
bzimport added a subscriber: Unknown Object (MLST).

Bryan.TongMinh wrote:

There is no codepath where ApiQueryAllimages can return an list item without the name key set. Can you provide an image and the shared repo where this occurs?

It is not present in 1.14, see r41303.

Fixed in r71436.

I didn't use the attached patch because creating a bunch of null titles would be useless. Without the 'name' attribute, findBySha1() isn't very helpful.